commit 2aefd994b7422516ff0da46f23d57fa203ba9027
author Michael Weghorn <m.weghorn@posteo.de> Tue Feb 24 09:43:56 2026 +0100
committer Andras Timar <andras.timar@collabora.com> Sun Mar 01 18:32:08 2026 +0100
tree 51f799511cf5398f6bc36cce6fb5b4d9b458b8a4
parent c83e1374893a54a8fbc776930162bc2bd3e0ee53

tdf#170805 extension mgr: Don't destroy dialog while still needed

    commit 5a6985c124c7a0ca246fbc920ab5e024d72a5e4a
    Author: Michael Weghorn <m.weghorn@posteo.de>
    Date:   Sat Nov 8 09:42:17 2025 +0100

        tdf#169318 extension mgr: Deduplicate close logic

extended TheExtensionManager::Close to also
reset TheExtensionManager::m_xExtMgrDialog, i.e.
delete the extension manager dialog.

That is fine for the callers newly added in the
above commit.

However, for the preexisting case in
ServiceImpl::startExecuteModal, the call to
TheExtensionManager::checkUpdates
a few lines above the call to
TheExtensionManager::Close triggers a separate
update thread that still wants to use the
dialog after it gets closed, causing a crash.

(Can be triggered e.g. by installing older
version 6.3 of the LanguageTool extension [1],
then "Help" -> "Check for Updates", closing
that dialog, then clicking the "Updates for extensions
available" button in the menu bar; requires a build
with --enable-online-update enabled.)

Don't destroy the dialog there, but only close
the dialog itself, by calling weld::Dialog::response
instead.

Make the "destructive" TheExtensionManager::Close
private.

[1] https://extensions.libreoffice.org/en/extensions/show/languagetool

Change-Id: I370b357fe4db435489366afbf1b3003770d6a209
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/200151
Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
Tested-by: Jenkins
(cherry picked from commit 5f626a166ed8b7917c8acc40652a7dcc696fa137)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/200271
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>