Gitiles
Code Review Sign In
gerrit.collaboraoffice.com / core / 57068786d24ef00fc2996bc9d12d56b530bb70f0
commit57068786d24ef00fc2996bc9d12d56b530bb70f0[log] [tgz]
authorMiklos Vajna <vmiklos@collabora.com>Fri Mar 20 15:02:06 2026 +0100
committerCaolán McNamara <caolan.mcnamara@collabora.com>Mon Mar 23 11:14:00 2026 +0100
tree5a9247d299a67d208651119e49637cb5e9cd05c8
parent51f44b7c149d7869cd025dc83a245ed03bea0517 [diff]
cool#15133 sd: fix missing LOK read-only handling in FuDraw::DoubleClick()

Regression from online.git commit
3cf8a2f1f161270fb0a85863bea1d5277e92eed3 (cool#10630 doc electronic
sign: fix outgoing mouse messages on 2nd page, 2025-01-27), click
somewhere on the 2nd page of a PDF file in LOK mode, the view jumps to
page 1, while nothing should happen.

This "worked" previously because the JS client had a bug and we sent an
out-of-page coordinate for the mouse click, so nothing happened, while
now it started text edit on the only graphic object on the page. One big
image for each page is the expected model for pdfium-based import
result, but adding text to images in a read-only view is not wanted.

Fix the problem by improving sd::FuDraw::DoubleClick() to check for
LokReadOnlyView next to the existing ReadOnly, which should improve
things in general for multiple LOK views where some of them are
read-only and others are read-write.

Change-Id: Id862c0e143366f7f6fec07576ef5bad8729a0a72
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/202252
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
2 files changed
tree: 5a9247d299a67d208651119e49637cb5e9cd05c8
  1. .config/
  2. .cspell/
  3. .git-hooks/
  4. .github/
  5. .vscode/
  6. android/
  7. animations/
  8. apple_remote/
  9. avmedia/
  10. basctl/
  11. basegfx/
  12. basic/
  13. bean/
  14. bin/
  15. binaryurp/
  16. bridges/
  17. canvas/
  18. chart2/
  19. cli_ure/
  20. codemaker/
  21. comphelper/
  22. compilerplugins/
  23. config_host/
  24. configmgr/
  25. connectivity/
  26. cppcanvas/
  27. cppu/
  28. cppuhelper/
  29. cpputools/
  30. cui/
  31. dbaccess/
  32. desktop/
  33. distro-configs/
  34. docmodel/
  35. drawinglayer/
  36. editeng/
  37. embeddedobj/
  38. embedserv/
  39. emfio/
  40. eventattacher/
  41. extensions/
  42. external/
  43. extras/
  44. filter/
  45. forms/
  46. formula/
  47. fpicker/
  48. framework/
  49. helpcompiler/
  50. hwpfilter/
  51. i18nlangtag/
  52. i18npool/
  53. i18nutil/
  54. icon-themes/
  55. idl/
  56. idlc/
  57. include/
  58. instsetoo_native/
  59. io/
  60. ios/
  61. javaunohelper/
  62. jurt/
  63. jvmaccess/
  64. jvmfwk/
  65. l10ntools/
  66. librelogo/
  67. libreofficekit/
  68. lingucomponent/
  69. linguistic/
  70. lotuswordpro/
  71. m4/
  72. msicreator/
  73. net_ure/
  74. nlpsolver/
  75. o3tl/
  76. odk/
  77. offapi/
  78. officecfg/
  79. oovbaapi/
  80. oox/
  81. opencl/
  82. osx/
  83. package/
  84. pch/
  85. postprocess/
  86. pyuno/
  87. qadevOOo/
  88. readlicense_oo/
  89. registry/
  90. remotebridges/
  91. reportbuilder/
  92. reportdesign/
  93. ridljar/
  94. rust_uno/
  95. sal/
  96. salhelper/
  97. sax/
  98. sc/
  99. scaddins/
  100. sccomp/
  101. schema/
  102. scp2/
  103. scripting/
  104. sd/
  105. sdext/
  106. setup_native/
  107. sfx2/
  108. shell/
  109. slideshow/
  110. smoketest/
  111. solenv/
  112. soltools/
  113. sot/
  114. starmath/
  115. static/
  116. stoc/
  117. store/
  118. svgio/
  119. svl/
  120. svtools/
  121. svx/
  122. sw/
  123. swext/
  124. sysui/
  125. test/
  126. testtools/
  127. toolkit/
  128. tools/
  129. ucb/
  130. ucbhelper/
  131. udkapi/
  132. uitest/
  133. UnoControls/
  134. unodevtools/
  135. unoidl/
  136. unoil/
  137. unotest/
  138. unotools/
  139. unoxml/
  140. ure/
  141. uui/
  142. vbahelper/
  143. vcl/
  144. winaccessibility/
  145. wizards/
  146. writerperfect/
  147. xmlhelp/
  148. xmloff/
  149. xmlreader/
  150. xmlscript/
  151. xmlsecurity/
  152. dictionaries
  153. helpcontent2
  154. translations
  155. .vsconfig ⇨ .config/2022.vsconfig
  156. .buckconfig
  157. .buckversion
  158. .clang-format
  159. .editorconfig
  160. .git-blame-ignore-revs
  161. .gitattributes
  162. .gitignore
  163. .gitmodules
  164. .gitpod.dockerfile
  165. .gitpod.yml
  166. .gitreview
  167. antivirusDetection.vbs
  168. autogen.sh
  169. BUCK
  170. config.guess
  171. config.sub
  172. config_host.mk.in
  173. config_host_lang.mk.in
  174. configure.ac
  175. COPYING
  176. COPYING.LGPL
  177. COPYING.MPL
  178. cpp.hint
  179. download.lst
  180. g
  181. install-sh
  182. install_deps.sh
  183. leak-suppress.txt
  184. Library_merged.mk
  185. logerrit
  186. Makefile.fetch
  187. Makefile.gbuild
  188. Makefile.in
  189. README.cross
  190. README.help.md
  191. README.md
  192. README.Solaris
  193. README.yrs
  194. Repository.mk
  195. RepositoryExternal.mk
  196. RepositoryFixes.mk
  197. RepositoryModule_build.mk
  198. RepositoryModule_host.mk
  199. sanitize-ubsan-excludelist
  200. setup.cfg
  201. TEMPLATE.SOURCECODE.HEADER
  202. tsan-suppress.txt
README.md

LibreOffice

Coverity Scan Build Status CII Best Practices Translation status

LibreOffice is an integrated office suite based on copyleft licenses and compatible with most document formats and standards. Libreoffice is backed by The Document Foundation, which represents a large independent community of enterprises, developers and other volunteers moved by the common goal of bringing to the market the best software for personal productivity. LibreOffice is open source, and free to download, use and distribute.

A quick overview of the LibreOffice code structure.

Overview

You can develop for LibreOffice in one of two ways, one recommended and one much less so. First the somewhat less recommended way: it is possible to use the SDK to develop an extension, for which you can read the API docs and Developers Guide. This re-uses the (extremely generic) UNO APIs that are also used by macro scripting in StarBasic.

The best way to add a generally useful feature to LibreOffice is to work on the code base however. Overall this way makes it easier to compile and build your code, it avoids any arbitrary limitations of our scripting APIs, and in general is far more simple and intuitive - if you are a reasonably able C++ programmer.

The Build Chain and Runtime Baselines

These are the current minimal operating system and compiler versions to run and compile LibreOffice, also used by the TDF builds:

  • Windows:
  • macOS:
    • Runtime: 11
    • Build: 13 or later + Xcode 14.3 or later (using latest version available for a given version of macOS)
  • Linux:
    • Runtime: RHEL 9 or CentOS 9 and comparable
    • Build: either GCC 12; or Clang 18 with libstdc++ 11
  • iOS (only for LibreOfficeKit):
    • Runtime: 14.5 (only support for newer i devices == 64 bit)
    • Build: Xcode 12.5 and iPhone SDK 14.5
  • Android:
    • Build: NDK 27 and SDK 30.0.3
  • Emscripten / WASM:
    • Runtime: a browser with SharedMemory support (threads + atomics)
    • Build: Qt 5.15 with Qt supported Emscripten 1.39.8
    • See README.wasm

Java is required for building many parts of LibreOffice. In TDF Wiki article Development/Java, the exact modules that depend on Java are listed.

The baseline for Java is Java Development Kit (JDK) Version 17 or later.

The baseline for Python is version 3.11. It follows the version available in SUSE Linux Enterprise Desktop and the Maintenance Support version of Red Hat Enterprise Linux.

If you want to use Clang with the LibreOffice compiler plugins, the minimal version of Clang is 18. Since Xcode doesn't provide the compiler plugin headers, you have to compile your own Clang to use them on macOS.

You can find the TDF configure switches in the distro-configs/ directory.

To setup your initial build environment on Windows and macOS, we provide the LibreOffice Development Environment (LODE) scripts.

For more information see the build instructions for your platform in the TDF wiki.

The Important Bits of Code

Each module should have a README.md file inside it which has some degree of documentation for that module; patches are most welcome to improve those. We have those turned into a web page here:

https://docs.libreoffice.org/

However, there are two hundred modules, many of them of only peripheral interest for a specialist audience. So - where is the good stuff, the code that is most useful. Here is a quick overview of the most important ones:

ModuleDescription
sal/this provides a simple System Abstraction Layer
tools/this provides basic internal types: Rectangle, Color etc.
vcl/this is the widget toolkit library and one rendering abstraction
framework/UNO framework, responsible for building toolbars, menus, status bars, and the chrome around the document using widgets from VCL, and XML descriptions from /uiconfig/ files
sfx2/legacy core framework used by Writer/Calc/Draw: document model / load/save / signals for actions etc.
svx/drawing model related helper code, including much of Draw/Impress

Then applications

ModuleDescription
desktop/this is where the main() for the application lives, init / bootstrap. the name dates back to an ancient StarOffice that also drew a desktop
sw/Writer
sc/Calc
sd/Draw / Impress

There are several other libraries that are helpful from a graphical perspective:

ModuleDescription
basegfx/algorithms and data-types for graphics as used in the canvas
canvas/new (UNO) canvas rendering model with various backends
cppcanvas/C++ helper classes for using the UNO canvas
drawinglayer/View code to render drawable objects and break them down into primitives we can render more easily.

Rules for #include Directives (C/C++)

Use the "..." form if and only if the included file is found next to the including file. Otherwise, use the <...> form. (For further details, see the mail Re: C[++]: Normalizing include syntax ("" vs <>).)

The UNO API include files should consistently use double quotes, for the benefit of external users of this API.

loplugin:includeform (compilerplugins/clang/includeform.cxx) enforces these rules.

Finding Out More

Beyond this, you can read the README.md files, send us patches, ask on the mailing list libreoffice@lists.freedesktop.org (no subscription required) or poke people on IRC #libreoffice-dev on irc.libera.chat - we're a friendly and generally helpful mob. We know the code can be hard to get into at first, and so there are no silly questions.

SAST Tools

PVS-Studio - static analyzer for C, C++, C#, and Java code.