)]}'
{
  "commit": "fe8240112db49c6713bccc15c4cc6d4f77f19648",
  "tree": "f870165a1af5291c9701bdd3bc110068deaba0f7",
  "parents": [
    "7ba970bce9e1200e5712afe76ec3a85056be9263"
  ],
  "author": {
    "name": "Stephan Bergmann",
    "email": "stephan.bergmann@collabora.com",
    "time": "Wed Apr 01 10:05:25 2026 +0200"
  },
  "committer": {
    "name": "Michael Stahl",
    "email": "michael.stahl@collabora.com",
    "time": "Thu Apr 02 15:07:48 2026 +0000"
  },
  "message": "Avoid premature downcast\n\nWith 98cc40cc57ef4bbdc272f43b0a9989f48d157707 \"ubsan: fix downcast\",\nCppunitTest_sc_vba_macro_test had started to occasionally fail for me with\n\n\u003e svx/source/sidebar/area/AreaPropertyPanelBase.cxx:1091:62: runtime error: downcast of address 0x7b0316a41b20 which does not point to an object of type \u0027const XFillTransparenceItem\u0027\n\u003e 0x7b0316a41b20: note: object is of type \u0027(anonymous namespace)::InvalidItem\u0027\n\u003e  00 00 00 00  10 a4 5b 16 03 7b 00 00  00 00 00 00 00 00 00 00  00 00 00 00 09 00 00 00  00 00 00 00\n\u003e               ^~~~~~~~~~~~~~~~~~~~~~~\n\u003e               vptr for \u0027(anonymous namespace)::InvalidItem\u0027\n\u003e  #0 in svx::sidebar::AreaPropertyPanelBase::NotifyItemUpdate(unsigned short, SfxItemState, SfxPoolItem const*) at svx/source/sidebar/area/AreaPropertyPanelBase.cxx:1091:62\n\u003e  #1 in sfx2::sidebar::ControllerItem::ReceiverNotifyItemUpdate(unsigned short, SfxItemState, SfxPoolItem const*) at sfx2/source/sidebar/ControllerItem.cxx:65:26\n\u003e  #2 in sfx2::sidebar::ControllerItem::StateChangedAtToolBoxControl(unsigned short, SfxItemState, SfxPoolItem const*) at sfx2/source/sidebar/ControllerItem.cxx:73:5\n\u003e  #3 in SfxStateCache::SetState_Impl(SfxItemState, SfxPoolItem const*, bool) at sfx2/source/control/statcach.cxx:428:24\n\u003e  #4 in SfxStateCache::SetState(SfxItemState, SfxPoolItem const*, bool) at sfx2/source/control/statcach.cxx:335:5\n\u003e  #5 in SfxBindings::UpdateControllers_Impl(SfxFoundCache_Impl const\u0026, SfxPoolItem const*, SfxItemState) at sfx2/source/control/bindings.cxx:1188:16\n\u003e  #6 in SfxBindings::Update_Impl(SfxStateCache\u0026) at sfx2/source/control/bindings.cxx:278:17\n\u003e  #7 in SfxBindings::NextJob_Impl(Timer const*) at sfx2/source/control/bindings.cxx:1264:17\n\u003e  #8 in SfxBindings::NextJob(Timer*) at sfx2/source/control/bindings.cxx:1209:5\n\u003e  #9 in SfxBindings::LinkStubNextJob(void*, Timer*) at sfx2/source/control/bindings.cxx:1204:25\n\u003e  #10 in Link\u003cTimer*, void\u003e::Call(Timer*) const at include/tools/link.hxx:105:45\n\u003e  #11 in Timer::Invoke() at vcl/source/app/timer.cxx:75:21\n\u003e  #12 in Scheduler::CallbackTaskScheduling() at vcl/source/app/scheduler.cxx:615:20\n\u003e  #13 in SalTimer::CallCallback() at vcl/inc/saltimer.hxx:53:13\n\u003e  #14 in SvpSalInstance::CheckTimeout(bool) at vcl/headless/svpinst.cxx:171:53\n\u003e  #15 in SvpSalInstance::ImplYield(bool, bool) at vcl/headless/svpinst.cxx:447:17\n\u003e  #16 in SvpSalInstance::DoYield(bool, bool) at vcl/headless/svpinst.cxx:519:21\n\u003e  #17 in InnerYield(bool, bool) at vcl/source/app/svapp.cxx:389:48\n\u003e  #18 in Application::Reschedule(bool) at vcl/source/app/svapp.cxx:415:17\n\u003e  #19 in SbiRuntime::Step() at basic/source/runtime/runtime.cxx:775:17\n\u003e  #20 in (anonymous namespace)::RunInitGuard::run() at basic/source/classes/sbxmod.cxx:1029:27\n\u003e  #21 in SbModule::Run(SbMethod*) at basic/source/classes/sbxmod.cxx:1189:31\n\u003e  #22 in SbModule::Notify(SfxBroadcaster\u0026, SfxHint const\u0026) at basic/source/classes/sbxmod.cxx:783:17\n\u003e  #23 in SfxBroadcaster::Broadcast(SfxHint const\u0026) at svl/source/notify/SfxBroadcaster.cxx:43:24\n\u003e  #24 in SbMethod::Broadcast(SfxHintId) at basic/source/classes/sbxmod.cxx:2124:20\n\u003e  #25 in SbxValue::SbxValue(SbxValue const\u0026) at basic/source/sbx/sbxvalue.cxx:67:36\n\u003e  #26 in SbxVariable::SbxVariable(SbxVariable const\u0026) at basic/source/sbx/sbxvar.cxx:48:7\n\u003e  #27 in SbxMethod::SbxMethod(SbxMethod const\u0026) at basic/source/sbx/sbxobj.cxx:841:7\n\u003e  #28 in SbiRuntime::FindElement(SbxObject*, unsigned int, unsigned int, ErrCode, bool, bool) at basic/source/runtime/runtime.cxx:3700:37\n\u003e  #29 in SbiRuntime::StepFIND_Impl(SbxObject*, unsigned int, unsigned int, ErrCode, bool) at basic/source/runtime/runtime.cxx:4142:14\n\u003e  #30 in SbiRuntime::StepFIND(unsigned int, unsigned int) at basic/source/runtime/runtime.cxx:4148:5\n\u003e  #31 in SbiRuntime::Step() at basic/source/runtime/runtime.cxx:805:13\n\u003e  #32 in (anonymous namespace)::RunInitGuard::run() at basic/source/classes/sbxmod.cxx:1029:27\n\u003e  #33 in SbModule::Run(SbMethod*) at basic/source/classes/sbxmod.cxx:1189:31\n\u003e  #34 in SbModule::Notify(SfxBroadcaster\u0026, SfxHint const\u0026) at basic/source/classes/sbxmod.cxx:783:17\n\u003e  #35 in SfxBroadcaster::Broadcast(SfxHint const\u0026) at svl/source/notify/SfxBroadcaster.cxx:43:24\n\u003e  #36 in SbMethod::Broadcast(SfxHintId) at basic/source/classes/sbxmod.cxx:2124:20\n\u003e  #37 in SbxValue::SbxValue(SbxValue const\u0026) at basic/source/sbx/sbxvalue.cxx:67:36\n\u003e  #38 in SbxVariable::SbxVariable(SbxVariable const\u0026) at basic/source/sbx/sbxvar.cxx:48:7\n\u003e  #39 in SbxMethod::SbxMethod(SbxMethod const\u0026) at basic/source/sbx/sbxobj.cxx:841:7\n\u003e  #40 in SbiRuntime::FindElement(SbxObject*, unsigned int, unsigned int, ErrCode, bool, bool) at basic/source/runtime/runtime.cxx:3700:37\n\u003e  #41 in SbiRuntime::StepFIND_Impl(SbxObject*, unsigned int, unsigned int, ErrCode, bool) at basic/source/runtime/runtime.cxx:4142:14\n\u003e  #42 in SbiRuntime::StepFIND(unsigned int, unsigned int) at basic/source/runtime/runtime.cxx:4148:5\n\u003e  #43 in SbiRuntime::Step() at basic/source/runtime/runtime.cxx:805:13\n\u003e  #44 in (anonymous namespace)::RunInitGuard::run() at basic/source/classes/sbxmod.cxx:1029:27\n\u003e  #45 in SbModule::Run(SbMethod*) at basic/source/classes/sbxmod.cxx:1189:31\n\u003e  #46 in SbModule::Notify(SfxBroadcaster\u0026, SfxHint const\u0026) at basic/source/classes/sbxmod.cxx:783:17\n\u003e  #47 in SfxBroadcaster::Broadcast(SfxHint const\u0026) at svl/source/notify/SfxBroadcaster.cxx:43:24\n\u003e  #48 in SbMethod::Broadcast(SfxHintId) at basic/source/classes/sbxmod.cxx:2124:20\n\u003e  #49 in SbxValue::Get(SbxValues\u0026) const at basic/source/sbx/sbxvalue.cxx:289:16\n\u003e  #50 in SbMethod::Call(SbxValue*, SbxVariable*) at basic/source/classes/sbxmod.cxx:2080:5\n\u003e  #51 in basprov::BasicScriptImpl::invoke(com::sun::star::uno::Sequence\u003ccom::sun::star::uno::Any\u003e const\u0026, com::sun::star::uno::Sequence\u003cshort\u003e\u0026, com::sun::star::uno::Sequence\u003ccom::sun::star::uno::Any\u003e\u0026) at scripting/source/basprov/basscript.cxx:262:35\n\u003e  #52 in non-virtual thunk to basprov::BasicScriptImpl::invoke(com::sun::star::uno::Sequence\u003ccom::sun::star::uno::Any\u003e const\u0026, com::sun::star::uno::Sequence\u003cshort\u003e\u0026, com::sun::star::uno::Sequence\u003ccom::sun::star::uno::Any\u003e\u0026) at scripting/source/basprov/basscript.cxx\n\u003e  #53 in SfxObjectShell::CallXScript(com::sun::star::uno::Reference\u003ccom::sun::star::uno::XInterface\u003e const\u0026, rtl::OUString const\u0026, com::sun::star::uno::Sequence\u003ccom::sun::star::uno::Any\u003e const\u0026, com::sun::star::uno::Any\u0026, com::sun::star::uno::Sequence\u003cshort\u003e\u0026, com::sun::star::uno::Sequence\u003ccom::sun::star::uno::Any\u003e\u0026, bool, com::sun::star::uno::Any const*) at sfx2/source/doc/objmisc.cxx:1557:25\n\u003e  #54 in UnoApiTest::executeMacro(rtl::OUString const\u0026, com::sun::star::uno::Sequence\u003ccom::sun::star::uno::Any\u003e const\u0026) at test/source/unoapi_test.cxx:341:22\n\u003e  #55 in testVba::TestBody() at sc/qa/extras/vba-macro-test.cxx:425:25\n\nChange-Id: Ic99db107d01400ceb4783915b361133399ec39d2\nReviewed-on: https://gerrit.collaboraoffice.com/c/core/+/35\nReviewed-by: Michael Stahl \u003cmichael.stahl@collabora.com\u003e\nTested-by: Jenkins CPCI \u003creleng@collaboraoffice.com\u003e\nReviewed-by: Noel Grandin \u003cnoel.grandin@collabora.com\u003e\n",
  "tree_diff": [
    {
      "type": "modify",
      "old_id": "60278f9f88a422e627a716204bb4c77ae057ac8a",
      "old_mode": 33188,
      "old_path": "svx/source/sidebar/area/AreaPropertyPanelBase.cxx",
      "new_id": "6ee4e60b3fef55f05b6505dff5169a761aaa23fa",
      "new_mode": 33188,
      "new_path": "svx/source/sidebar/area/AreaPropertyPanelBase.cxx"
    }
  ]
}