| commit | 15843ed45a7b807506f7cf3529f9e15dd77e4b8b | [log] [tgz] |
|---|---|---|
| author | Stephan Bergmann <sbergman@redhat.com> | Mon Oct 08 11:21:45 2018 +0200 |
| committer | Tor Lillqvist <tml@iki.fi> | Tue Dec 04 21:40:25 2018 +0200 |
| tree | 6de60ee760d3e38c936363268ff631fd5097dcc0 | |
| parent | f3ad7d68a83b623201b31a4e07b2dff93f60e5de [diff] |
tdf#121778: Work around odd macOS 10.14 graphicsContextWithWindow failure Although Stephan's original commit message below talks mainly about a unit test, this change helps at least in tdf#121778, too, and possibly other cases. It is interesting that wihout this change, a lot of these warnings are printed before the crash: warn:vcl.quartz:42670:52899343:vcl/quartz/salvd.cxx:312: No context Original commit message: When running on macOS 10.14, both master and libreoffice-6-1 (at least) started to fail CppunitTest_vcl_bitmap_render_test with > /Users/stephan/Software/lo2/core/vcl/qa/cppunit/bitmaprender/BitmapRenderTest.cxx:90: Assertion > Test name: BitmapRenderTest::testTdf113918 > equality assertion failed > - Expected: mcBlueOrIndex: 255, mcGreen: 255, mcRed: 255, mcAlpha: 0 > - Actual : mcBlueOrIndex: 1, mcGreen: 112, mcRed: 15, mcAlpha: 0 in --enable-debug/--enable-dbgutil builds. I tracked that down to the OSL_DEBUG_LEVEL>0--only call to Scheduler::ProcessEventsToIdle in test::BootstrapFixture::setUp (test/source/bootstrapfixture.cxx). If that call is also included in non-debug (i.e., OSL_DEBUG_LEVEL=0) builds, or if it is removed from all builds and instead an unsuspecting [NSApp nextEventMatchingMask: 0 untilDate: nil inMode: NSDefaultRunLoopMode dequeue: NO]; is added directly before the call to pVDev->SetOutputSizePixel(Size(2480, 3508)); at the start of BitmapRenderTest::testTdf113918 (vcl/qa/cppunit/bitmaprender/BitmapRenderTest.cxx:76), the test always fails. What happens is that, after such a nextEventMatchingMask call done, the call to NSGraphicsContext graphicsContextWithWindow in AquaSalVirtualDevice::SetSize (as called from the SetOutputSizePixel call in the test) returns nil, for unclear reasons. Until those underlying reasons are understood, change the code of SetSize to "fall back to a bitmap context" also in case the graphicsContextWithWindow call returned nil. Reviewed-on: https://gerrit.libreoffice.org/61519 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com> (cherry picked from commit e659c6a1857fbb8e5a6e8ff60fe241483eea32dd) Change-Id: I604ebd2c444b58610e4ed73ec70af87b0a08e864
- .git-hooks/
- accessibility/
- android/
- animations/
- apple_remote/
- avmedia/
- basctl/
- basegfx/
- basic/
- bean/
- bin/
- binaryurp/
- bridges/
- canvas/
- chart2/
- cli_ure/
- codemaker/
- comphelper/
- compilerplugins/
- config_host/
- configmgr/
- connectivity/
- cppcanvas/
- cppu/
- cppuhelper/
- cpputools/
- cui/
- dbaccess/
- desktop/
- distro-configs/
- drawinglayer/
- dtrans/
- editeng/
- embeddedobj/
- embedserv/
- emfio/
- eventattacher/
- extensions/
- external/
- extras/
- filter/
- forms/
- formula/
- fpicker/
- framework/
- helpcompiler/
- hwpfilter/
- i18nlangtag/
- i18npool/
- i18nutil/
- icon-themes/
- idl/
- idlc/
- include/
- instsetoo_native/
- io/
- ios/
- javaunohelper/
- jurt/
- jvmaccess/
- jvmfwk/
- l10ntools/
- librelogo/
- libreofficekit/
- lingucomponent/
- linguistic/
- lotuswordpro/
- m4/
- mysqlc/
- nlpsolver/
- o3tl/
- odk/
- offapi/
- officecfg/
- onlineupdate/
- oovbaapi/
- oox/
- opencl/
- osx/
- package/
- postprocess/
- pyuno/
- qadevOOo/
- readlicense_oo/
- registry/
- remotebridges/
- reportbuilder/
- reportdesign/
- ridljar/
- sal/
- salhelper/
- sax/
- sc/
- scaddins/
- sccomp/
- schema/
- scp2/
- scripting/
- sd/
- sdext/
- setup_native/
- sfx2/
- shell/
- slideshow/
- smoketest/
- solenv/
- soltools/
- sot/
- starmath/
- stoc/
- store/
- svgio/
- svl/
- svtools/
- svx/
- sw/
- swext/
- sysui/
- test/
- testtools/
- toolkit/
- tools/
- ucb/
- ucbhelper/
- udkapi/
- uitest/
- UnoControls/
- unodevtools/
- unoidl/
- unoil/
- unotest/
- unotools/
- unoxml/
- ure/
- uui/
- vbahelper/
- vcl/
- winaccessibility/
- wizards/
- writerfilter/
- writerperfect/
- xmerge/
- xmlhelp/
- xmloff/
- xmlreader/
- xmlscript/
- xmlsecurity/
- dictionaries
- helpcontent2
- translations
- .buckconfig
- .buckversion
- .clang-format
- .editorconfig
- .gitattributes
- .gitignore
- .gitmodules
- .gitreview
- autogen.sh
- BUCK
- config.guess
- config.sub
- config_host.mk.in
- config_host_lang.mk.in
- configure.ac
- COPYING
- COPYING.LGPL
- COPYING.MPL
- download.lst
- g
- install-sh
- leak-suppress.txt
- Library_merged.mk
- lo.xcent.in
- logerrit
- Makefile.fetch
- Makefile.gbuild
- Makefile.in
- README.cross
- README.md
- README.Solaris
- Repository.mk
- RepositoryExternal.mk
- RepositoryFixes.mk
- RepositoryModule_build.mk
- RepositoryModule_host.mk
- sanitize-ubsan-blacklist
- TEMPLATE.SOURCECODE.HEADER
LibreOffice
LibreOffice is an integrated office suite based on copyleft licenses and compatible with most document formats and standards. Libreoffice is backed by The Document Foundation, which represents a large independent community of enterprises, developers and other volunteers moved by the common goal of bringing to the market the best software for personal productivity. LibreOffice is open source, and free to download, use and distribute.
A quick overview of the LibreOffice code structure.
Overview
You can develop for LibreOffice in one of two ways, one recommended and one much less so. First the somewhat less recommended way: it is possible to use the SDK to develop an extension, for which you can read the API docs here and here. This re-uses the (extremely generic) UNO APIs that are also used by macro scripting in StarBasic.
The best way to add a generally useful feature to LibreOffice is to work on the code base however. Overall this way makes it easier to compile and build your code, it avoids any arbitrary limitations of our scripting APIs, and in general is far more simple and intuitive - if you are a reasonably able C++ programmer.
The build chain and runtime baselines
These are the current minimal operating system and compiler versions to run and compile LibreOffice, also used by the TDF builds:
- Windows:
- Runtime: Windows 7
- Build: Cygwin + Visual Studio 2015 Update 3
- macOS:
- Runtime: 10.9
- Build: 10.12 + Xcode 8
- Linux:
- Runtime: RHEL 6 or CentOS 6
- Build: GCC 4.8.1 or Clang
- iOS (only for LibreOfficeKit):
- Runtime: 11.3 (only support for newer i devices == 64 bit)
- Build: Xcode 9.3 and iPhone SDK 11.3
At least Clang 3.4.2 is known to be too old to pass the configure.ac check "whether $CXX supports C++17, C++14, or C++11" in its current form (due to the #pragma GCC diagnostic ignored "-Wpragmas" that it does not understand).
If you want to use Clang with the LibreOffice compiler plugins, the minimal version of Clang is 3.8. Since Xcode doesn't provide the compiler plugin headers, you have to compile your own Clang to use them on macOS.
You can find the TDF configure switches in the distro-configs/ directory.
To setup your initial build environment on Windows and macOS, we provide the LibreOffice Development Environment (LODE) scripts.
For more information see the build instructions for your platform in the TDF wiki.
The important bits of code
Each module should have a README file inside it which has some degree of documentation for that module; patches are most welcome to improve those. We have those turned into a web page here:
However, there are two hundred modules, many of them of only peripheral interest for a specialist audience. So - where is the good stuff, the code that is most useful. Here is a quick overview of the most important ones:
| Module | Description |
|---|---|
| sal/ | this provides a simple System Abstraction Layer |
| tools/ | this provides basic internal types: 'Rectangle', 'Color' etc. |
| vcl/ | this is the widget toolkit library and one rendering abstraction |
| framework | UNO framework, responsible for building toolbars, menus, status bars, and the chrome around the document using widgets from VCL, and XML descriptions from /uiconfig/ files |
| sfx2/ | legacy core framework used by Writer/Calc/Draw: document model / load/save / signals for actions etc. |
| svx/ | drawing model related helper code, including much of Draw/Impress |
Then applications
| Module | Description |
|---|---|
| desktop/ | this is where the 'main' for the application lives, init / bootstrap. the name dates back to an ancient StarOffice that also drew a desktop |
| sw/ | Writer |
| sc/ | Calc |
| sd/ | Draw / Impress |
There are several other libraries that are helpful from a graphical perspective:
| Module | Description |
|---|---|
| basegfx/ | algorithms and data-types for graphics as used in the canvas |
| canvas/ | new (UNO) canvas rendering model with various backends |
| cppcanvas/ | C++ helper classes for using the UNO canvas |
| drawinglayer/ | View code to render drawable objects and break them down into primitives we can render more easily. |
Rules for #include directives (C/C++)
Use the "..." form if and only if the included file is found next to the including file. Otherwise, use the <...> form. (For further details, see the mail Re: C[++]: Normalizing include syntax ("" vs <>).)
The UNO API include files should consistently use double quotes, for the benefit of external users of this API.
Finding out more
Beyond this, you can read the README files, send us patches, ask on the mailing list libreoffice@lists.freedesktop.org (no subscription required) or poke people on IRC #libreoffice-dev on irc.freenode.net - we're a friendly and generally helpful mob. We know the code can be hard to get into at first, and so there are no silly questions.