Gitiles
Code Review Sign In
gerrit.collaboraoffice.com / core / 5d969ce25538238066aaa3879746aae95959d03d
commit5d969ce25538238066aaa3879746aae95959d03d[log] [tgz]
authorStephan Bergmann <sbergman@redhat.com>Fri Apr 22 21:52:50 2022 +0200
committerAron Budea <aron.budea@collabora.com>Thu May 30 21:39:13 2024 +0200
tree41d88568d8c091a0c13b3670df62c4372abf34c9
parentabe1e391f2a5f190984d8bafd7f9613639cb93b1 [diff]
external/libassuan: Fix fallout of defining __STDC__ on Windows

...since 1bb0e177124d5d6661b72df6c7d848fb23639652 "Fix autoconf>=2.70
gcc-wrapper breakage", which had the side effect of preventing various
deprecated function declarations in system headers (e.g., isascii in addition to
__isascii).  This went unnoticed so far due to the traditionally lax handling of
missing function declarations in C, and only now started to cause

> conversion.c(94,9): error: call to undeclared function 'isascii'; ISO C99 and later do not support implicit function declarations [-Wimplicit-function-declaration]
>           if ((isascii (*istr) && isprint (*istr)) || (*istr >= 0x80))
>                ^

etc. with clang-cl 15 trunk after
<https://github.com/llvm/llvm-project/commit/7d644e1215b376ec5e915df9ea2eeb56e2d94626>
"[C11/C2x] Change the behavior of the implicit function declaration warning".

Where undeclared functions have been used in Windows-only code, they have been
replaced with their __STDC__-declared counterparts, and for occurrences in
shared code Windows-only macro definitions have been introduced (as would have
done in the system headers too, if __STDC__ was not defined) to not clutter the
shared code with #ifdefs.

Also, for getpid (resp. _getpid), the #include <process.h> was apparently
missing from the upstream code, even without our __STDC__ hack in
external/libassuan/ExternalProject_libassuan.mk (but never caused errors until
now, either).

Change-Id: I7442394d0c6e633bca1f6c7331d7ee51651179a4
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133339
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
(cherry picked from commit 8279d89d6e037def78f50c72fab2116ca56bef52)
(cherry picked from commit 1f683fe50fe0e850a7a978228a71c84356b38cf6)
2 files changed
tree: 41d88568d8c091a0c13b3670df62c4372abf34c9
  1. .git-hooks/
  2. .github/
  3. accessibility/
  4. android/
  5. animations/
  6. apple_remote/
  7. avmedia/
  8. basctl/
  9. basegfx/
  10. basic/
  11. bean/
  12. bin/
  13. binaryurp/
  14. bridges/
  15. canvas/
  16. chart2/
  17. cli_ure/
  18. codemaker/
  19. comphelper/
  20. compilerplugins/
  21. config_host/
  22. configmgr/
  23. connectivity/
  24. cppcanvas/
  25. cppu/
  26. cppuhelper/
  27. cpputools/
  28. cui/
  29. dbaccess/
  30. desktop/
  31. distro-configs/
  32. drawinglayer/
  33. dtrans/
  34. editeng/
  35. embeddedobj/
  36. embedserv/
  37. emfio/
  38. eventattacher/
  39. extensions/
  40. external/
  41. extras/
  42. filter/
  43. forms/
  44. formula/
  45. fpicker/
  46. framework/
  47. helpcompiler/
  48. hwpfilter/
  49. i18nlangtag/
  50. i18npool/
  51. i18nutil/
  52. icon-themes/
  53. idl/
  54. idlc/
  55. include/
  56. instsetoo_native/
  57. io/
  58. ios/
  59. javaunohelper/
  60. jurt/
  61. jvmaccess/
  62. jvmfwk/
  63. l10ntools/
  64. librelogo/
  65. libreofficekit/
  66. lingucomponent/
  67. linguistic/
  68. lotuswordpro/
  69. m4/
  70. nlpsolver/
  71. o3tl/
  72. odk/
  73. offapi/
  74. officecfg/
  75. onlineupdate/
  76. oovbaapi/
  77. oox/
  78. opencl/
  79. osx/
  80. package/
  81. pch/
  82. postprocess/
  83. pyuno/
  84. qadevOOo/
  85. readlicense_oo/
  86. registry/
  87. remotebridges/
  88. reportbuilder/
  89. reportdesign/
  90. ridljar/
  91. sal/
  92. salhelper/
  93. sax/
  94. sc/
  95. scaddins/
  96. sccomp/
  97. schema/
  98. scp2/
  99. scripting/
  100. sd/
  101. sdext/
  102. setup_native/
  103. sfx2/
  104. shell/
  105. slideshow/
  106. smoketest/
  107. solenv/
  108. soltools/
  109. sot/
  110. starmath/
  111. stoc/
  112. store/
  113. svgio/
  114. svl/
  115. svtools/
  116. svx/
  117. sw/
  118. swext/
  119. sysui/
  120. test/
  121. testtools/
  122. toolkit/
  123. tools/
  124. ucb/
  125. ucbhelper/
  126. udkapi/
  127. uitest/
  128. UnoControls/
  129. unodevtools/
  130. unoidl/
  131. unoil/
  132. unotest/
  133. unotools/
  134. unoxml/
  135. ure/
  136. uui/
  137. vbahelper/
  138. vcl/
  139. winaccessibility/
  140. wizards/
  141. writerfilter/
  142. writerperfect/
  143. xmerge/
  144. xmlhelp/
  145. xmloff/
  146. xmlreader/
  147. xmlscript/
  148. xmlsecurity/
  149. dictionaries
  150. helpcontent2
  151. translations
  152. .buckconfig
  153. .buckversion
  154. .clang-format
  155. .editorconfig
  156. .git-blame-ignore-revs
  157. .gitattributes
  158. .gitignore
  159. .gitmodules
  160. .gitpod.dockerfile
  161. .gitpod.yml
  162. .gitreview
  163. antivirusDetection.vbs
  164. autogen.sh
  165. BUCK
  166. config.guess
  167. config.sub
  168. config_host.mk.in
  169. config_host_lang.mk.in
  170. configure.ac
  171. COPYING
  172. COPYING.LGPL
  173. COPYING.MPL
  174. download.lst
  175. g
  176. hardened_runtime.xcent.in
  177. install-sh
  178. leak-suppress.txt
  179. Library_merged.mk
  180. lo.xcent
  181. logerrit
  182. Makefile.fetch
  183. Makefile.gbuild
  184. Makefile.in
  185. README.cross
  186. README.md
  187. README.Solaris
  188. Repository.mk
  189. RepositoryExternal.mk
  190. RepositoryFixes.mk
  191. RepositoryModule_build.mk
  192. RepositoryModule_host.mk
  193. sanitize-ubsan-blacklist
  194. setup.cfg
  195. TEMPLATE.SOURCECODE.HEADER
README.md

LibreOffice

Coverity Scan Build Status CII Best Practices Translation status

LibreOffice is an integrated office suite based on copyleft licenses and compatible with most document formats and standards. Libreoffice is backed by The Document Foundation, which represents a large independent community of enterprises, developers and other volunteers moved by the common goal of bringing to the market the best software for personal productivity. LibreOffice is open source, and free to download, use and distribute.

A quick overview of the LibreOffice code structure.

Overview

You can develop for LibreOffice in one of two ways, one recommended and one much less so. First the somewhat less recommended way: it is possible to use the SDK to develop an extension, for which you can read the API docs here and here. This re-uses the (extremely generic) UNO APIs that are also used by macro scripting in StarBasic.

The best way to add a generally useful feature to LibreOffice is to work on the code base however. Overall this way makes it easier to compile and build your code, it avoids any arbitrary limitations of our scripting APIs, and in general is far more simple and intuitive - if you are a reasonably able C++ programmer.

The build chain and runtime baselines

These are the current minimal operating system and compiler versions to run and compile LibreOffice, also used by the TDF builds:

  • Windows:
    • Runtime: Windows 7
    • Build: Cygwin + Visual Studio 2019 version 16.4
  • macOS:
    • Runtime: 10.10
    • Build: 10.14.4 + Xcode 11.3
  • Linux:
    • Runtime: RHEL 7 or CentOS 7
    • Build: either GCC 7.0.0; or Clang 5.0.2 with libstdc++ 7.3.0
  • iOS (only for LibreOfficeKit):
    • Runtime: 11.4 (only support for newer i devices == 64 bit)
    • Build: Xcode 9.3 and iPhone SDK 11.4
  • Android:
    • Build: NDK r19c and SDK 22.6.2

If you want to use Clang with the LibreOffice compiler plugins, the minimal version of Clang is 5.0.2. Since Xcode doesn't provide the compiler plugin headers, you have to compile your own Clang to use them on macOS.

You can find the TDF configure switches in the distro-configs/ directory.

To setup your initial build environment on Windows and macOS, we provide the LibreOffice Development Environment (LODE) scripts.

For more information see the build instructions for your platform in the TDF wiki.

The important bits of code

Each module should have a README file inside it which has some degree of documentation for that module; patches are most welcome to improve those. We have those turned into a web page here:

https://docs.libreoffice.org/

However, there are two hundred modules, many of them of only peripheral interest for a specialist audience. So - where is the good stuff, the code that is most useful. Here is a quick overview of the most important ones:

ModuleDescription
sal/this provides a simple System Abstraction Layer
tools/this provides basic internal types: 'Rectangle', 'Color' etc.
vcl/this is the widget toolkit library and one rendering abstraction
frameworkUNO framework, responsible for building toolbars, menus, status bars, and the chrome around the document using widgets from VCL, and XML descriptions from /uiconfig/ files
sfx2/legacy core framework used by Writer/Calc/Draw: document model / load/save / signals for actions etc.
svx/drawing model related helper code, including much of Draw/Impress

Then applications

ModuleDescription
desktop/this is where the 'main' for the application lives, init / bootstrap. the name dates back to an ancient StarOffice that also drew a desktop
sw/Writer
sc/Calc
sd/Draw / Impress

There are several other libraries that are helpful from a graphical perspective:

ModuleDescription
basegfx/algorithms and data-types for graphics as used in the canvas
canvas/new (UNO) canvas rendering model with various backends
cppcanvas/C++ helper classes for using the UNO canvas
drawinglayer/View code to render drawable objects and break them down into primitives we can render more easily.

Rules for #include directives (C/C++)

Use the "..." form if and only if the included file is found next to the including file. Otherwise, use the <...> form. (For further details, see the mail Re: C[++]: Normalizing include syntax ("" vs <>).)

The UNO API include files should consistently use double quotes, for the benefit of external users of this API.

loplugin:includeform (compilerplugins/clang/includeform.cxx) enforces these rules.

Finding out more

Beyond this, you can read the README files, send us patches, ask on the mailing list libreoffice@lists.freedesktop.org (no subscription required) or poke people on IRC #libreoffice-dev on irc.freenode.net - we're a friendly and generally helpful mob. We know the code can be hard to get into at first, and so there are no silly questions.