Gitiles
Code Review Sign In
gerrit.collaboraoffice.com / core / refs/heads/feature/cib_contract49d
commit0f5deee363fd0f9f611f4644d662d83380b1a130[log] [tgz]
authorNoel Grandin <noelgrandin@gmail.com>Thu Mar 26 16:05:06 2026 +0200
committerThorsten Behrens <thorsten.behrens@collabora.com>Fri Mar 27 17:58:55 2026 +0100
tree35daa4c8005f1dc6d3e59116cd70d9100f0107b3
parentb03f50b0949f8f7f180c6c27f69cc315612e6025 [diff]
fix crash on Windows in JunitTest_chart2_unoapi

no idea what changed to make this happen more often, but it
looks like a latent issue. The problem is that the chart code
is calling dispose() on vcl stuff, a Toolbox in this case, which
happens to be in the middle of a paint, and then the Toolbox
crashes. Work around it by adding some more checks for
isDisposed().

The disposing stack looks like:
32: ToolBox::dispose - 0x7ff9dbc857d2
31: VclReferenceBase::disposeOnce - 0x7ff9dbeaf969
30: VclPtr<ToolBox>::disposeAndClear - 0x7ff9f451be23
29: framework::`anonymous namespace'::VclToolBarManager::Destroy - 0x7ff9f450d86d
28: framework::ToolBarManager::Destroy - 0x7ff9f450d29b
27: framework::ToolBarManager::dispose - 0x7ff9f451bbf8
26: framework::ToolBarWrapper::dispose - 0x7ff9f4522b61
25: framework::ToolbarLayoutManager::destroyToolbars - 0x7ff9f43a9562
24: framework::ToolbarLayoutManager::reset - 0x7ff9f43b99b3
23: framework::LayoutManager::implts_reset - 0x7ff9f4392c87
22: framework::LayoutManager::frameAction - 0x7ff9f438cb54
21: `anonymous namespace'::XFrameImpl::implts_sendFrameActionEvent - 0x7ff9f4404c85
20: `anonymous namespace'::XFrameImpl::setComponent - 0x7ff9f440a6ed
19: `anonymous namespace'::XFrameImpl::close - 0x7ff9f43fbbea
18: chart::ChartController::notifyClosing - 0x7ff9d529ddbd
17: comphelper::OInterfaceContainerHelper4<com::sun::star::util::XCloseListener>::NotifySingleListener<com::sun::star::lang::EventObject>::operator() - 0x7ff9d54eb919
16: comphelper::OInterfaceContainerHelper4<com::sun::star::util::XCloseListener>::forEach<comphelper::OInterfaceContainerHelper4<com::sun::star::util::XCloseListener>::NotifySingleListener<com::sun::star::lang::EventObject> > - 0x7ff9d54e4f7f
15: comphelper::OInterfaceContainerHelper4<com::sun::star::util::XCloseListener>::notifyEach<com::sun::star::lang::EventObject> - 0x7ff9d54e5157
14: apphelper::CloseableLifeTimeManager::impl_doClose - 0x7ff9d5606c82
13: apphelper::CloseableLifeTimeManager::g_close_endTryClose_doClose - 0x7ff9d5606719
12: chart::ChartModel::close - 0x7ff9d54ee527
11: `anonymous namespace'::cpp_call - 0x7ffa5b9e3d9a
10: unoInterfaceProxyDispatch - 0x7ffa5b9e4e2a
9: binaryurp::IncomingRequest::execute_throw - 0x7ff9f576eed7
8: binaryurp::IncomingRequest::execute - 0x7ff9f576dfb2
7: request - 0x7ff9f578a856
6: cppu_threadpool::JobQueue::enter - 0x7ffa593b7f82
5: cppu_threadpool::ORequestThread::run - 0x7ffa593bfc96
4: threadFunc - 0x7ffa593c083c
3: oslWorkerWrapperFunction - 0x7ffa1190b17a
2: register_onexit_function - 0x7ffa59552ec5
1: BaseThreadInitThunk - 0x7ffa80a67374
0: RtlUserThreadStart - 0x7ffa80e5cc91

Change-Id: I12c2b63ffa2cc84248d19610baf52a5418474b25
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/202748
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
1 file changed
tree: 35daa4c8005f1dc6d3e59116cd70d9100f0107b3
  1. .git-hooks/
  2. .github/
  3. .vscode/
  4. accessibility/
  5. android/
  6. animations/
  7. apple_remote/
  8. avmedia/
  9. basctl/
  10. basegfx/
  11. basic/
  12. bean/
  13. bin/
  14. binaryurp/
  15. bridges/
  16. canvas/
  17. chart2/
  18. cli_ure/
  19. codemaker/
  20. comphelper/
  21. compilerplugins/
  22. config_host/
  23. configmgr/
  24. connectivity/
  25. cppcanvas/
  26. cppu/
  27. cppuhelper/
  28. cpputools/
  29. cui/
  30. dbaccess/
  31. desktop/
  32. distro-configs/
  33. docmodel/
  34. drawinglayer/
  35. editeng/
  36. embeddedobj/
  37. embedserv/
  38. emfio/
  39. eventattacher/
  40. extensions/
  41. external/
  42. extras/
  43. filter/
  44. forms/
  45. formula/
  46. fpicker/
  47. framework/
  48. helpcompiler/
  49. hwpfilter/
  50. i18nlangtag/
  51. i18npool/
  52. i18nutil/
  53. icon-themes/
  54. idl/
  55. idlc/
  56. include/
  57. instsetoo_native/
  58. io/
  59. ios/
  60. javaunohelper/
  61. jurt/
  62. jvmaccess/
  63. jvmfwk/
  64. l10ntools/
  65. librelogo/
  66. libreofficekit/
  67. lingucomponent/
  68. linguistic/
  69. lotuswordpro/
  70. m4/
  71. msicreator/
  72. nlpsolver/
  73. o3tl/
  74. odk/
  75. offapi/
  76. officecfg/
  77. oovbaapi/
  78. oox/
  79. opencl/
  80. osx/
  81. package/
  82. pch/
  83. postprocess/
  84. pyuno/
  85. qadevOOo/
  86. readlicense_oo/
  87. registry/
  88. remotebridges/
  89. reportbuilder/
  90. reportdesign/
  91. ridljar/
  92. sal/
  93. salhelper/
  94. sax/
  95. sc/
  96. scaddins/
  97. sccomp/
  98. schema/
  99. scp2/
  100. scripting/
  101. sd/
  102. sdext/
  103. setup_native/
  104. sfx2/
  105. shell/
  106. slideshow/
  107. smoketest/
  108. solenv/
  109. soltools/
  110. sot/
  111. starmath/
  112. static/
  113. stoc/
  114. store/
  115. svgio/
  116. svl/
  117. svtools/
  118. svx/
  119. sw/
  120. swext/
  121. sysui/
  122. test/
  123. testtools/
  124. toolkit/
  125. tools/
  126. ucb/
  127. ucbhelper/
  128. udkapi/
  129. uitest/
  130. UnoControls/
  131. unodevtools/
  132. unoidl/
  133. unoil/
  134. unotest/
  135. unotools/
  136. unoxml/
  137. ure/
  138. uui/
  139. vbahelper/
  140. vcl/
  141. winaccessibility/
  142. wizards/
  143. writerperfect/
  144. xmerge/
  145. xmlhelp/
  146. xmloff/
  147. xmlreader/
  148. xmlscript/
  149. xmlsecurity/
  150. dictionaries
  151. helpcontent2
  152. translations
  153. .buckconfig
  154. .buckversion
  155. .clang-format
  156. .editorconfig
  157. .git-blame-ignore-revs
  158. .gitattributes
  159. .gitignore
  160. .gitmodules
  161. .gitpod.dockerfile
  162. .gitpod.yml
  163. .gitreview
  164. antivirusDetection.vbs
  165. autogen.sh
  166. BUCK
  167. config.guess
  168. config.sub
  169. config_host.mk.in
  170. config_host_lang.mk.in
  171. configure.ac
  172. COPYING
  173. COPYING.LGPL
  174. COPYING.MPL
  175. cpp.hint
  176. download.lst
  177. g
  178. install-sh
  179. install_deps.sh
  180. leak-suppress.txt
  181. Library_merged.mk
  182. logerrit
  183. Makefile.fetch
  184. Makefile.gbuild
  185. Makefile.in
  186. README.cross
  187. README.help.md
  188. README.md
  189. README.Solaris
  190. Repository.mk
  191. RepositoryExternal.mk
  192. RepositoryFixes.mk
  193. RepositoryModule_build.mk
  194. RepositoryModule_host.mk
  195. sanitize-ubsan-excludelist
  196. setup.cfg
  197. TEMPLATE.SOURCECODE.HEADER
  198. tsan-suppress.txt
README.md

LibreOffice

Coverity Scan Build Status CII Best Practices Translation status

LibreOffice is an integrated office suite based on copyleft licenses and compatible with most document formats and standards. Libreoffice is backed by The Document Foundation, which represents a large independent community of enterprises, developers and other volunteers moved by the common goal of bringing to the market the best software for personal productivity. LibreOffice is open source, and free to download, use and distribute.

A quick overview of the LibreOffice code structure.

Overview

You can develop for LibreOffice in one of two ways, one recommended and one much less so. First the somewhat less recommended way: it is possible to use the SDK to develop an extension, for which you can read the API docs and Developers Guide. This re-uses the (extremely generic) UNO APIs that are also used by macro scripting in StarBasic.

The best way to add a generally useful feature to LibreOffice is to work on the code base however. Overall this way makes it easier to compile and build your code, it avoids any arbitrary limitations of our scripting APIs, and in general is far more simple and intuitive - if you are a reasonably able C++ programmer.

The Build Chain and Runtime Baselines

These are the current minimal operating system and compiler versions to run and compile LibreOffice, also used by the TDF builds:

  • Windows:
    • Runtime: Windows 7
    • Build: Cygwin + Visual Studio 2019 version 16.10
  • macOS:
    • Runtime: 10.15
    • Build: 12 (13 for aarch64) + Xcode 14
  • Linux:
    • Runtime: RHEL 8 or CentOS 8 and comparable
    • Build: either GCC 12; or Clang 12 with libstdc++ 10
  • iOS (only for LibreOfficeKit):
    • Runtime: 11.4 (only support for newer i devices == 64 bit)
    • Build: Xcode 9.3 and iPhone SDK 11.4
  • Android:
    • Build: NDK r23 and SDK 30.0.3
  • Emscripten / WASM:
    • Runtime: a browser with SharedMemory support (threads + atomics)
    • Build: Qt 5.15 with Qt supported Emscripten 1.39.8
    • See README.wasm

Java is required for building many parts of LibreOffice. In TDF Wiki article Development/Java, the exact modules that depend on Java are listed.

The baseline for Java is Java Development Kit (JDK) Version 17 or later.

If you want to use Clang with the LibreOffice compiler plugins, the minimal version of Clang is 12.0.1. Since Xcode doesn't provide the compiler plugin headers, you have to compile your own Clang to use them on macOS.

You can find the TDF configure switches in the distro-configs/ directory.

To setup your initial build environment on Windows and macOS, we provide the LibreOffice Development Environment (LODE) scripts.

For more information see the build instructions for your platform in the TDF wiki.

The Important Bits of Code

Each module should have a README.md file inside it which has some degree of documentation for that module; patches are most welcome to improve those. We have those turned into a web page here:

https://docs.libreoffice.org/

However, there are two hundred modules, many of them of only peripheral interest for a specialist audience. So - where is the good stuff, the code that is most useful. Here is a quick overview of the most important ones:

ModuleDescription
sal/this provides a simple System Abstraction Layer
tools/this provides basic internal types: Rectangle, Color etc.
vcl/this is the widget toolkit library and one rendering abstraction
framework/UNO framework, responsible for building toolbars, menus, status bars, and the chrome around the document using widgets from VCL, and XML descriptions from /uiconfig/ files
sfx2/legacy core framework used by Writer/Calc/Draw: document model / load/save / signals for actions etc.
svx/drawing model related helper code, including much of Draw/Impress

Then applications

ModuleDescription
desktop/this is where the main() for the application lives, init / bootstrap. the name dates back to an ancient StarOffice that also drew a desktop
sw/Writer
sc/Calc
sd/Draw / Impress

There are several other libraries that are helpful from a graphical perspective:

ModuleDescription
basegfx/algorithms and data-types for graphics as used in the canvas
canvas/new (UNO) canvas rendering model with various backends
cppcanvas/C++ helper classes for using the UNO canvas
drawinglayer/View code to render drawable objects and break them down into primitives we can render more easily.

Rules for #include Directives (C/C++)

Use the "..." form if and only if the included file is found next to the including file. Otherwise, use the <...> form. (For further details, see the mail Re: C[++]: Normalizing include syntax ("" vs <>).)

The UNO API include files should consistently use double quotes, for the benefit of external users of this API.

loplugin:includeform (compilerplugins/clang/includeform.cxx) enforces these rules.

Finding Out More

Beyond this, you can read the README.md files, send us patches, ask on the mailing list libreoffice@lists.freedesktop.org (no subscription required) or poke people on IRC #libreoffice-dev on irc.libera.chat - we're a friendly and generally helpful mob. We know the code can be hard to get into at first, and so there are no silly questions.