)]}' { "log": [ { "commit": "8215006a9d60d055f5de558f013dc666db19f53e", "tree": "bba946b57ce94cbfd859c44553f30498f7a013e1", "parents": [ "4048c36c29c9888af2d923dfa16e1dd299fc9de6" ], "author": { "name": "Gabor Kelemen", "email": "gabor.kelemen@collabora.com", "time": "Fri Jan 23 20:11:14 2026 +0100" }, "committer": { "name": "Gabor Kelemen", "email": "gabor.kelemen@collabora.com", "time": "Sat Jan 31 20:55:03 2026 +0100" }, "message": "tdf#146619 Use more forward declarations in include/ucbhelper/\n\nChange-Id: I233162bb69e95c4b128e8189d1eb490a67c19ffa\nReviewed-on: https://gerrit.libreoffice.org/c/core/+/198236\nTested-by: Jenkins\nReviewed-by: Gabor Kelemen \u003cgabor.kelemen@collabora.com\u003e\n" }, { "commit": "004f16ca450f70d84fcfb87aebb95a7248b87d7f", "tree": "cabf9443d28893e46f00c2554a32409dc5c653f1", "parents": [ "dd07ab686814398cca145c48225b2caec2484296" ], "author": { "name": "Caolán McNamara", "email": "caolan.mcnamara@collabora.com", "time": "Sat Aug 02 13:11:53 2025 +0100" }, "committer": { "name": "Caolán McNamara", "email": "caolan.mcnamara@collabora.com", "time": "Sat Aug 02 16:20:00 2025 +0200" }, "message": "cid#1660859 Variable copied when it could be moved\n\nand\n\ncid#1660535 Variable copied when it could be moved\ncid#1660533 Variable copied when it could be moved\ncid#1660519 Variable copied when it could be moved\ncid#1660518 Variable copied when it could be moved\ncid#1660516 Variable copied when it could be moved\ncid#1660504 Variable copied when it could be moved\ncid#1660497 Variable copied when it could be moved\ncid#1660493 Variable copied when it could be moved\ncid#1660490 Variable copied when it could be moved\ncid#1660489 Variable copied when it could be moved\n\nChange-Id: I44be3d401c56fd6d5183dcd1ee6f8efef52b305e\nReviewed-on: https://gerrit.libreoffice.org/c/core/+/188821\nReviewed-by: Caolán McNamara \u003ccaolan.mcnamara@collabora.com\u003e\nTested-by: Jenkins\n" }, { "commit": "d022499adacdc753065d79af56608c034de07b5d", "tree": "b40b9afa99c7284e2af05852b0f52f74d745a7e0", "parents": [ "74147823a7c933c796239b00cd9bf89edb899eb3" ], "author": { "name": "Simon Chenery", "email": "simon_chenery@yahoo.com", "time": "Sun Mar 16 16:44:49 2025 +0100" }, "committer": { "name": "Ilmari Lauhakangas", "email": "ilmari.lauhakangas@libreoffice.org", "time": "Mon Mar 17 16:29:16 2025 +0100" }, "message": "tdf#143148: Use pragma once instead of include guards in ucbhelper\n\nChange-Id: Ic6e59aa0d46f6acf47b4c327fafc6de9ceecd01f\nReviewed-on: https://gerrit.libreoffice.org/c/core/+/183007\nReviewed-by: Ilmari Lauhakangas \u003cilmari.lauhakangas@libreoffice.org\u003e\nTested-by: Jenkins\nTested-by: Ilmari Lauhakangas \u003cilmari.lauhakangas@libreoffice.org\u003e\n" }, { "commit": "a1da8b21e37dce9019a696ec4174283721b92648", "tree": "3e26f5f44ea9ae30192ba82436e4a700106b00a3", "parents": [ "6b620171f6b3fb15f48890d46fb6e8fb51bfd383" ], "author": { "name": "Noel Grandin", "email": "noel.grandin@collabora.co.uk", "time": "Thu Jan 16 13:30:23 2025 +0200" }, "committer": { "name": "Noel Grandin", "email": "noel.grandin@collabora.co.uk", "time": "Thu Jan 16 14:16:33 2025 +0100" }, "message": "SimpleCertificateValidationRequest is unused\n\nsince\n commit 9413f2b39cb48417d75dfd3b5a28dac18541839e\n Author: Michael Stahl \u003cmichael.stahl@allotropia.de\u003e\n Date: Fri Jun 21 16:23:24 2024 +0200\n ucb: cmis: remove CertValidationHandler\n\nChange-Id: Iee66db682081ddcb7da9a6276acf3261a637f315\nReviewed-on: https://gerrit.libreoffice.org/c/core/+/180341\nTested-by: Jenkins\nReviewed-by: Noel Grandin \u003cnoel.grandin@collabora.co.uk\u003e\n" }, { "commit": "e512091e89f2489e8b4a5dd5a19880b508c6867b", "tree": "d0ddc35ce5b39a5fe754d63a2396d4686a7d6fb7", "parents": [ "a1b8b44bf99b331f6cd4b4583d08b6a01d5c4f03" ], "author": { "name": "Mike Kaganski", "email": "mike.kaganski@collabora.com", "time": "Sun Dec 08 23:50:13 2024 +0500" }, "committer": { "name": "Mike Kaganski", "email": "mike.kaganski@collabora.com", "time": "Mon Dec 09 05:26:24 2024 +0100" }, "message": "Simplify InteractionContinuation and derivatives\n\nChange-Id: Ib7294cc09255f7563ae14488ab7fb56d02092dc4\nReviewed-on: https://gerrit.libreoffice.org/c/core/+/178117\nTested-by: Jenkins\nReviewed-by: Mike Kaganski \u003cmike.kaganski@collabora.com\u003e\n" }, { "commit": "a34d9e36193821fdbc8fb7d6b3527daf076b2069", "tree": "1dce27319e0701699013916758775b3b84b8b8a3", "parents": [ "ec3850e661e40c146edd55c6ad1fce3996e421c4" ], "author": { "name": "Noel Grandin", "email": "noel.grandin@collabora.co.uk", "time": "Tue Nov 12 21:02:56 2024 +0200" }, "committer": { "name": "Noel Grandin", "email": "noel.grandin@collabora.co.uk", "time": "Wed Nov 13 06:35:19 2024 +0100" }, "message": "loplugin:reftotemp in scripting..uui\n\nChange-Id: I6953958b4429dd0fa1a44d02b0b49618f97baf90\nReviewed-on: https://gerrit.libreoffice.org/c/core/+/176500\nTested-by: Jenkins\nReviewed-by: Noel Grandin \u003cnoel.grandin@collabora.co.uk\u003e\n" }, { "commit": "92f5913aef0668f1de5a20631128c84ad932fd99", "tree": "9a46b9ba1039de892a4e7e13fc4e06dc95f61e08", "parents": [ "c235e6af9192db19cbbe6f8b00112a1f6534375e" ], "author": { "name": "Caolán McNamara", "email": "caolan.mcnamara@collabora.com", "time": "Tue Nov 05 20:04:17 2024 +0000" }, "committer": { "name": "Caolán McNamara", "email": "caolan.mcnamara@collabora.com", "time": "Wed Nov 06 13:58:54 2024 +0100" }, "message": "cid#1556442 COPY_INSTEAD_OF_MOVE\n\nand\n\ncid#1607753 COPY_INSTEAD_OF_MOVE\ncid#1554790 COPY_INSTEAD_OF_MOVE\ncid#1556463 COPY_INSTEAD_OF_MOVE\ncid#1554838 COPY_INSTEAD_OF_MOVE\ncid#1556231 COPY_INSTEAD_OF_MOVE\ncid#1556878 COPY_INSTEAD_OF_MOVE\ncid#1554913 COPY_INSTEAD_OF_MOVE\ncid#1558064 COPY_INSTEAD_OF_MOVE\ncid#1557043 COPY_INSTEAD_OF_MOVE\ncid#1556985 COPY_INSTEAD_OF_MOVE\ncid#1556766 COPY_INSTEAD_OF_MOVE\ncid#1557351 COPY_INSTEAD_OF_MOVE\ncid#1554863 COPY_INSTEAD_OF_MOVE\ncid#1556764 COPY_INSTEAD_OF_MOVE\ncid#1556279 COPY_INSTEAD_OF_MOVE\ncid#1555970 COPY_INSTEAD_OF_MOVE\ncid#1556942 COPY_INSTEAD_OF_MOVE\ncid#1557964 COPY_INSTEAD_OF_MOVE\ncid#1555166 COPY_INSTEAD_OF_MOVE\ncid#1556496 COPY_INSTEAD_OF_MOVE\ncid#1557175 COPY_INSTEAD_OF_MOVE\ncid#1558054 COPY_INSTEAD_OF_MOVE\ncid#1557392 COPY_INSTEAD_OF_MOVE\ncid#1557850 COPY_INSTEAD_OF_MOVE\ncid#1555118 COPY_INSTEAD_OF_MOVE\ncid#1557131 COPY_INSTEAD_OF_MOVE\ncid#1556614 COPY_INSTEAD_OF_MOVE\ncid#1609650 COPY_INSTEAD_OF_MOVE\ncid#1555114 COPY_INSTEAD_OF_MOVE\ncid#1555241 COPY_INSTEAD_OF_MOVE\ncid#1555442 COPY_INSTEAD_OF_MOVE\ncid#1556473 COPY_INSTEAD_OF_MOVE\ncid#1557654 COPY_INSTEAD_OF_MOVE\ncid#1554689 COPY_INSTEAD_OF_MOVE\ncid#1556316 COPY_INSTEAD_OF_MOVE\ncid#1557929 COPY_INSTEAD_OF_MOVE\ncid#1554807 COPY_INSTEAD_OF_MOVE\ncid#1554858 COPY_INSTEAD_OF_MOVE\ncid#1555103 COPY_INSTEAD_OF_MOVE\ncid#1555517 COPY_INSTEAD_OF_MOVE\ncid#1556424 COPY_INSTEAD_OF_MOVE\ncid#1557252 COPY_INSTEAD_OF_MOVE\ncid#1557566 COPY_INSTEAD_OF_MOVE\ncid#1608020 COPY_INSTEAD_OF_MOVE\ncid#1557742 COPY_INSTEAD_OF_MOVE\ncid#1555884 COPY_INSTEAD_OF_MOVE\ncid#1554809 COPY_INSTEAD_OF_MOVE\ncid#1555336 COPY_INSTEAD_OF_MOVE\ncid#1555173 COPY_INSTEAD_OF_MOVE\ncid#1556067 COPY_INSTEAD_OF_MOVE\ncid#1557040 COPY_INSTEAD_OF_MOVE\ncid#1556235 COPY_INSTEAD_OF_MOVE\ncid#1557366 COPY_INSTEAD_OF_MOVE\ncid#1555910 COPY_INSTEAD_OF_MOVE\ncid#1556716 COPY_INSTEAD_OF_MOVE\ncid#1558022 COPY_INSTEAD_OF_MOVE\ncid#1555769 COPY_INSTEAD_OF_MOVE\ncid#1555940 COPY_INSTEAD_OF_MOVE\ncid#1557077 COPY_INSTEAD_OF_MOVE\ncid#1555270 COPY_INSTEAD_OF_MOVE\ncid#1555660 COPY_INSTEAD_OF_MOVE\ncid#1556302 COPY_INSTEAD_OF_MOVE\ncid#1555678 COPY_INSTEAD_OF_MOVE\ncid#1556538 COPY_INSTEAD_OF_MOVE\ncid#1557689 COPY_INSTEAD_OF_MOVE\ncid#1555009 COPY_INSTEAD_OF_MOVE\ncid#1555433 COPY_INSTEAD_OF_MOVE\ncid#1555671 COPY_INSTEAD_OF_MOVE\ncid#1555255 COPY_INSTEAD_OF_MOVE\ncid#1557681 COPY_INSTEAD_OF_MOVE\ncid#1557512 COPY_INSTEAD_OF_MOVE\ncid#1554958 COPY_INSTEAD_OF_MOVE\ncid#1555758 COPY_INSTEAD_OF_MOVE\ncid#1555597 COPY_INSTEAD_OF_MOVE\ncid#1558040 COPY_INSTEAD_OF_MOVE\ncid#1556476 COPY_INSTEAD_OF_MOVE\ncid#1557646 COPY_INSTEAD_OF_MOVE\ncid#1557950 COPY_INSTEAD_OF_MOVE\ncid#1557019 COPY_INSTEAD_OF_MOVE\ncid#1557885 COPY_INSTEAD_OF_MOVE\ncid#1556402 COPY_INSTEAD_OF_MOVE\ncid#1557906 COPY_INSTEAD_OF_MOVE\ncid#1556619 COPY_INSTEAD_OF_MOVE\ncid#1554683 COPY_INSTEAD_OF_MOVE\ncid#1556549 COPY_INSTEAD_OF_MOVE\ncid#1554747 COPY_INSTEAD_OF_MOVE\ncid#1554929 COPY_INSTEAD_OF_MOVE\ncid#1555362 COPY_INSTEAD_OF_MOVE\ncid#1557053 COPY_INSTEAD_OF_MOVE\ncid#1557891 COPY_INSTEAD_OF_MOVE\ncid#1555043 COPY_INSTEAD_OF_MOVE\ncid#1555107 COPY_INSTEAD_OF_MOVE\ncid#1557203 COPY_INSTEAD_OF_MOVE\ncid#1556728 COPY_INSTEAD_OF_MOVE\ncid#1557773 COPY_INSTEAD_OF_MOVE\ncid#1556845 COPY_INSTEAD_OF_MOVE\n\nChange-Id: I001fb67e597b096e992fd8a0cd6f3ec577767c33\nReviewed-on: https://gerrit.libreoffice.org/c/core/+/176098\nReviewed-by: Caolán McNamara \u003ccaolan.mcnamara@collabora.com\u003e\nTested-by: Jenkins\n" }, { "commit": "6f1508f4de761e564146f3111345270403838468", "tree": "4367c4e14e57177fea4dd28db803bfcd88243ca0", "parents": [ "7a35f3dc7419d833b8f47069c4df63e900ccb880" ], "author": { "name": "Caolán McNamara", "email": "caolan.mcnamara@collabora.com", "time": "Sat Oct 26 10:56:43 2024 +0100" }, "committer": { "name": "Caolán McNamara", "email": "caolan.mcnamara@collabora.com", "time": "Sat Oct 26 19:25:03 2024 +0200" }, "message": "cid#1555767 COPY_INSTEAD_OF_MOVE\n\nand\n\ncid#1555770 COPY_INSTEAD_OF_MOVE\ncid#1555788 COPY_INSTEAD_OF_MOVE\ncid#1555789 COPY_INSTEAD_OF_MOVE\ncid#1555798 COPY_INSTEAD_OF_MOVE\ncid#1555816 COPY_INSTEAD_OF_MOVE\ncid#1555822 COPY_INSTEAD_OF_MOVE\ncid#1555835 COPY_INSTEAD_OF_MOVE\ncid#1555845 COPY_INSTEAD_OF_MOVE\ncid#1555859 COPY_INSTEAD_OF_MOVE\ncid#1555864 COPY_INSTEAD_OF_MOVE\ncid#1555868 COPY_INSTEAD_OF_MOVE\ncid#1555892 COPY_INSTEAD_OF_MOVE\ncid#1555896 COPY_INSTEAD_OF_MOVE\ncid#1555921 COPY_INSTEAD_OF_MOVE\ncid#1555932 COPY_INSTEAD_OF_MOVE\ncid#1555935 COPY_INSTEAD_OF_MOVE\ncid#1555944 COPY_INSTEAD_OF_MOVE\ncid#1555952 COPY_INSTEAD_OF_MOVE\ncid#1555985 COPY_INSTEAD_OF_MOVE\ncid#1556024 COPY_INSTEAD_OF_MOVE\ncid#1556038 COPY_INSTEAD_OF_MOVE\ncid#1556042 COPY_INSTEAD_OF_MOVE\ncid#1556044 COPY_INSTEAD_OF_MOVE\ncid#1556060 COPY_INSTEAD_OF_MOVE\ncid#1556083 COPY_INSTEAD_OF_MOVE\ncid#1556085 COPY_INSTEAD_OF_MOVE\ncid#1556090 COPY_INSTEAD_OF_MOVE\ncid#1556136 COPY_INSTEAD_OF_MOVE\ncid#1556157 COPY_INSTEAD_OF_MOVE\ncid#1556159 COPY_INSTEAD_OF_MOVE\ncid#1556172 COPY_INSTEAD_OF_MOVE\ncid#1556179 COPY_INSTEAD_OF_MOVE\ncid#1556187 COPY_INSTEAD_OF_MOVE\ncid#1556255 COPY_INSTEAD_OF_MOVE\ncid#1556256 COPY_INSTEAD_OF_MOVE\ncid#1556266 COPY_INSTEAD_OF_MOVE\ncid#1556275 COPY_INSTEAD_OF_MOVE\ncid#1556290 COPY_INSTEAD_OF_MOVE\ncid#1556294 COPY_INSTEAD_OF_MOVE\ncid#1556301 COPY_INSTEAD_OF_MOVE\ncid#1556311 COPY_INSTEAD_OF_MOVE\ncid#1556318 COPY_INSTEAD_OF_MOVE\ncid#1556326 COPY_INSTEAD_OF_MOVE\ncid#1556369 COPY_INSTEAD_OF_MOVE\ncid#1556374 COPY_INSTEAD_OF_MOVE\ncid#1556387 COPY_INSTEAD_OF_MOVE\ncid#1556388 COPY_INSTEAD_OF_MOVE\ncid#1556417 COPY_INSTEAD_OF_MOVE\ncid#1556425 COPY_INSTEAD_OF_MOVE\ncid#1556435 COPY_INSTEAD_OF_MOVE\ncid#1556495 COPY_INSTEAD_OF_MOVE\ncid#1556497 COPY_INSTEAD_OF_MOVE\ncid#1556501 COPY_INSTEAD_OF_MOVE\ncid#1556503 COPY_INSTEAD_OF_MOVE\ncid#1556520 COPY_INSTEAD_OF_MOVE\ncid#1556523 COPY_INSTEAD_OF_MOVE\ncid#1556562 COPY_INSTEAD_OF_MOVE\ncid#1556573 COPY_INSTEAD_OF_MOVE\ncid#1556576 COPY_INSTEAD_OF_MOVE\ncid#1556598 COPY_INSTEAD_OF_MOVE\ncid#1556615 COPY_INSTEAD_OF_MOVE\ncid#1556626 COPY_INSTEAD_OF_MOVE\ncid#1556671 COPY_INSTEAD_OF_MOVE\ncid#1556689 COPY_INSTEAD_OF_MOVE\ncid#1556701 COPY_INSTEAD_OF_MOVE\ncid#1556713 COPY_INSTEAD_OF_MOVE\ncid#1556758 COPY_INSTEAD_OF_MOVE\ncid#1556759 COPY_INSTEAD_OF_MOVE\ncid#1556788 COPY_INSTEAD_OF_MOVE\ncid#1556811 COPY_INSTEAD_OF_MOVE\ncid#1556821 COPY_INSTEAD_OF_MOVE\ncid#1556824 COPY_INSTEAD_OF_MOVE\ncid#1556825 COPY_INSTEAD_OF_MOVE\ncid#1556862 COPY_INSTEAD_OF_MOVE\n\nChange-Id: I4925a79688a983bb07252600430039ec0bcb75b8\nReviewed-on: https://gerrit.libreoffice.org/c/core/+/175678\nReviewed-by: Caolán McNamara \u003ccaolan.mcnamara@collabora.com\u003e\nTested-by: Jenkins\n" }, { "commit": "5c4fac1e9f50832852e87452f3152f01b905f9e6", "tree": "bfa807b8f9c76f38bc490d279f96819276420125", "parents": [ "44bb2c82870f83776eb26d41aeb9defbee97b102" ], "author": { "name": "Noel Grandin", "email": "noel.grandin@collabora.co.uk", "time": "Wed Oct 16 13:19:05 2024 +0200" }, "committer": { "name": "Noel Grandin", "email": "noel.grandin@collabora.co.uk", "time": "Wed Oct 16 15:52:02 2024 +0200" }, "message": "loplugin:unusedmethods\n\nChange-Id: I6ba4b4046190b701d4a15c6fa90b6009ecf4ab1c\nReviewed-on: https://gerrit.libreoffice.org/c/core/+/175014\nTested-by: Jenkins\nReviewed-by: Noel Grandin \u003cnoel.grandin@collabora.co.uk\u003e\n" }, { "commit": "3b60abdc948f3101d2107bd515f4ca31b041bd04", "tree": "c08f6c40456e9b9c60ddede7373ed077b19a7897", "parents": [ "9ea9c6f0fc5e08167906b22817ad03c3fd072e62" ], "author": { "name": "Noel Grandin", "email": "noelgrandin@gmail.com", "time": "Tue Oct 01 19:23:34 2024 +0200" }, "committer": { "name": "Noel Grandin", "email": "noel.grandin@collabora.co.uk", "time": "Wed Oct 02 09:38:00 2024 +0200" }, "message": "cid#1608390 Data race condition\n\nChange-Id: I98a8addad50888e5969fce5bf47d67f96b06ecf0\nReviewed-on: https://gerrit.libreoffice.org/c/core/+/174359\nTested-by: Jenkins\nReviewed-by: Noel Grandin \u003cnoel.grandin@collabora.co.uk\u003e\n" }, { "commit": "9ea9c6f0fc5e08167906b22817ad03c3fd072e62", "tree": "2c5e1adb8054c435f2f82a804d28fb9974d17b81", "parents": [ "ba7199da2e6ec9d58475373f264326fbeb31f4bd" ], "author": { "name": "Noel Grandin", "email": "noelgrandin@gmail.com", "time": "Tue Oct 01 19:19:23 2024 +0200" }, "committer": { "name": "Noel Grandin", "email": "noel.grandin@collabora.co.uk", "time": "Wed Oct 02 09:37:52 2024 +0200" }, "message": "cid#1606901 Data race condition\n\nChange-Id: Id1d8f0895021719670c5419ab464c247ae3bf29c\nReviewed-on: https://gerrit.libreoffice.org/c/core/+/174358\nTested-by: Jenkins\nReviewed-by: Noel Grandin \u003cnoel.grandin@collabora.co.uk\u003e\n" }, { "commit": "da8a36b4f4fa86831dabbfe7794c835cd5f975b4", "tree": "35f494584d34bdd4744dd028fc50e8789e4aec2d", "parents": [ "080913a6b9159f11de93c106669c0a2f60db2ebc" ], "author": { "name": "Noel Grandin", "email": "noelgrandin@gmail.com", "time": "Sun Sep 29 19:27:50 2024 +0200" }, "committer": { "name": "Noel Grandin", "email": "noel.grandin@collabora.co.uk", "time": "Mon Sep 30 18:24:30 2024 +0200" }, "message": "CID#1607066:Data race condition (MISSING_LOCK)\n\nwhich means we need to push knowledge\nabout the locking down into ucbhelper::Result\nsince the implementation classes there\nwant to call back into the parent.\n\nand also\n\nCID#1607968:Data race condition (MISSING_LOCK)\nCID#1606657:Data race condition (MISSING_LOCK)\nCID#1607112:Data race condition (MISSING_LOCK)\nCID#1608365:Data race condition (MISSING_LOCK)\nCID#1607159:Data race condition (MISSING_LOCK)\nCID#1607018:Data race condition (MISSING_LOCK)\nCID#1607421:Data race condition (MISSING_LOCK)\nCID#1607766:Data race condition (MISSING_LOCK)\nCID#1606872:Data race condition (MISSING_LOCK)\nCID#1608523:Data race condition (MISSING_LOCK\nCID#1607191:Data race condition (MISSING_LOCK)\nCID#1608345:Data race condition (MISSING_LOCK)\nCID#1608577:(#1 of 1):Data race condition (MISSING_LOCK)\nCID#1607210:Data race condition (MISSING_LOCK)\nCID#1607132:Data race condition (MISSING_LOCK)\nCID#1608256:Data race condition (MISSING_LOCK)\nCID#1607482:Data race condition (MISSING_LOCK)\nCID#1607935:Data race condition (MISSING_LOCK)\nCID#1608070:Data race condition (MISSING_LOCK)\nCID#1607901:Data race condition (MISSING_LOCK)\nCID#1608013:Data race condition (MISSING_LOCK)\nCID#1607506:Data race condition (MISSING_LOCK)\nCID#1607526:Data race condition (MISSING_LOCK)\nCID#1607044:Data race condition (MISSING_LOCK)\nCID#1607708:Data race condition (MISSING_LOCK)\nCID#1608041:Data race condition (MISSING_LOCK)\nCID#1608207:Data race condition (MISSING_LOCK)\nCID#1608028:Data race condition (MISSING_LOCK)\nCID#1608168:Data race condition (MISSING_LOCK)\nCID#1607561:Data race condition (MISSING_LOCK)\n\nCID#1607689:Check of thread-shared field evades lock acquisition (LOCK_EVASION)\nCID#1607689:Check of thread-shared field evades lock acquisition (LOCK_EVASION)\nCID#1607689:Check of thread-shared field evades lock acquisition (LOCK_EVASION)\nCID#1607689:Check of thread-shared field evades lock acquisition (LOCK_EVASION)\nCID#1607689:Check of thread-shared field evades lock acquisition (LOCK_EVASION)\nCID#1607689:Check of thread-shared field evades lock acquisition (LOCK_EVASION)\nCID#1607689:Check of thread-shared field evades lock acquisition (LOCK_EVASION)\nCID#1607689:Check of thread-shared field evades lock acquisition (LOCK_EVASION)\nCID#1607689:Check of thread-shared field evades lock acquisition (LOCK_EVASION)\nCID#1607689:Check of thread-shared field evades lock acquisition (LOCK_EVASION)\n\nChange-Id: Ifbe908a4a86ab8c5fa1c4ed3b6f9466508e4900e\nReviewed-on: https://gerrit.libreoffice.org/c/core/+/174204\nTested-by: Jenkins\nReviewed-by: Noel Grandin \u003cnoel.grandin@collabora.co.uk\u003e\n" }, { "commit": "b922fb69982f41962740f2abebaccf13e8c357a4", "tree": "b83a12aeac599239949c2f71bd932c067d7423a3", "parents": [ "b103bcee12afacef5316081bdacb32fc2eeefa31" ], "author": { "name": "Noel Grandin", "email": "noel.grandin@collabora.co.uk", "time": "Tue Sep 10 13:09:03 2024 +0200" }, "committer": { "name": "Noel Grandin", "email": "noel.grandin@collabora.co.uk", "time": "Tue Sep 10 17:17:43 2024 +0200" }, "message": "use more concrete UNO type in ucbhelper\n\nChange-Id: I1ad512564e58aed731639dbf9dbb3e7d6ee7acef\nReviewed-on: https://gerrit.libreoffice.org/c/core/+/173137\nReviewed-by: Noel Grandin \u003cnoel.grandin@collabora.co.uk\u003e\nTested-by: Jenkins\n" }, { "commit": "c93eb54c872ea279ee43bbf0abe00cc92e9a72e2", "tree": "33bfb98083e33270a30a4242e983b941918bb2a9", "parents": [ "4551356827e7c506f76a3da744ac8c8d4a3d0fac" ], "author": { "name": "Caolán McNamara", "email": "caolan.mcnamara@collabora.com", "time": "Thu Aug 15 20:19:59 2024 +0100" }, "committer": { "name": "Caolán McNamara", "email": "caolan.mcnamara@collabora.com", "time": "Fri Aug 16 09:30:37 2024 +0200" }, "message": "cid#1557618 COPY_INSTEAD_OF_MOVE\n\nand\n\ncid#1557535 COPY_INSTEAD_OF_MOVE\ncid#1557520 COPY_INSTEAD_OF_MOVE\ncid#1557513 COPY_INSTEAD_OF_MOVE\ncid#1557503 COPY_INSTEAD_OF_MOVE\ncid#1557487 COPY_INSTEAD_OF_MOVE\ncid#1557483 COPY_INSTEAD_OF_MOVE\ncid#1557479 COPY_INSTEAD_OF_MOVE\ncid#1557474 COPY_INSTEAD_OF_MOVE\ncid#1557461 COPY_INSTEAD_OF_MOVE\ncid#1557446 COPY_INSTEAD_OF_MOVE\ncid#1557445 COPY_INSTEAD_OF_MOVE\ncid#1557441 COPY_INSTEAD_OF_MOVE\ncid#1557435 COPY_INSTEAD_OF_MOVE\ncid#1557433 COPY_INSTEAD_OF_MOVE\ncid#1557429 COPY_INSTEAD_OF_MOVE\ncid#1557375 COPY_INSTEAD_OF_MOVE\ncid#1557372 COPY_INSTEAD_OF_MOVE\ncid#1557356 COPY_INSTEAD_OF_MOVE\ncid#1557350 COPY_INSTEAD_OF_MOVE\ncid#1557344 COPY_INSTEAD_OF_MOVE\ncid#1557339 COPY_INSTEAD_OF_MOVE\ncid#1557332 COPY_INSTEAD_OF_MOVE\ncid#1557330 COPY_INSTEAD_OF_MOVE\ncid#1557328 COPY_INSTEAD_OF_MOVE\ncid#1557323 COPY_INSTEAD_OF_MOVE\ncid#1557315 COPY_INSTEAD_OF_MOVE\ncid#1557313 COPY_INSTEAD_OF_MOVE\ncid#1557304 COPY_INSTEAD_OF_MOVE\ncid#1557297 COPY_INSTEAD_OF_MOVE\ncid#1557291 COPY_INSTEAD_OF_MOVE\ncid#1557290 COPY_INSTEAD_OF_MOVE\ncid#1557271 COPY_INSTEAD_OF_MOVE\ncid#1557266 COPY_INSTEAD_OF_MOVE\ncid#1557262 COPY_INSTEAD_OF_MOVE\ncid#1557259 COPY_INSTEAD_OF_MOVE\ncid#1557246 COPY_INSTEAD_OF_MOVE\ncid#1557242 COPY_INSTEAD_OF_MOVE\ncid#1557241 COPY_INSTEAD_OF_MOVE\ncid#1557236 COPY_INSTEAD_OF_MOVE\ncid#1557228 COPY_INSTEAD_OF_MOVE\ncid#1557225 COPY_INSTEAD_OF_MOVE\ncid#1557221 COPY_INSTEAD_OF_MOVE\ncid#1557217 COPY_INSTEAD_OF_MOVE\ncid#1557213 COPY_INSTEAD_OF_MOVE\ncid#1557211 COPY_INSTEAD_OF_MOVE\ncid#1557209 COPY_INSTEAD_OF_MOVE\ncid#1557205 COPY_INSTEAD_OF_MOVE\ncid#1557204 COPY_INSTEAD_OF_MOVE\ncid#1557193 COPY_INSTEAD_OF_MOVE\ncid#1556082 COPY_INSTEAD_OF_MOVE\n\nChange-Id: I07f195a79a69d4bac0d14317854efc88d6fe94d7\nReviewed-on: https://gerrit.libreoffice.org/c/core/+/171927\nTested-by: Jenkins\nReviewed-by: Caolán McNamara \u003ccaolan.mcnamara@collabora.com\u003e\n" }, { "commit": "2d4aa7861cf036f503e19a6bac460e26b78aa27a", "tree": "d1349749639e9fa5af0cc1b17afcbf472d18cf80", "parents": [ "1cf263e8387a21e740d49890fe00a8e684a117cc" ], "author": { "name": "Caolán McNamara", "email": "caolan.mcnamara@collabora.com", "time": "Sun Jul 21 20:35:06 2024 +0100" }, "committer": { "name": "Caolán McNamara", "email": "caolan.mcnamara@collabora.com", "time": "Mon Jul 22 09:35:00 2024 +0200" }, "message": "cid#1608362 Double unlock\n\nand\n\ncid#1608276 Double lock\n\nChange-Id: I64529c0b9e9b4df2ee51a024522f82051ccea25d\nReviewed-on: https://gerrit.libreoffice.org/c/core/+/170824\nTested-by: Jenkins\nReviewed-by: Caolán McNamara \u003ccaolan.mcnamara@collabora.com\u003e\n" }, { "commit": "f4c7ffc8edf83529550eb3897024792cbb6e48e0", "tree": "1e5cfa04696d2680c790e45983a21ee93310f96c", "parents": [ "98142886f21e40d0f7052f18108d9586f4b2fbc5" ], "author": { "name": "Noel Grandin", "email": "noel.grandin@collabora.co.uk", "time": "Thu May 16 09:28:47 2024 +0200" }, "committer": { "name": "Noel Grandin", "email": "noel.grandin@collabora.co.uk", "time": "Thu May 16 14:49:15 2024 +0200" }, "message": "loplugin:ostr in ucbhelper\n\nChange-Id: Ic0513708b208ec4cba54eedc15e308410eef8d98\nReviewed-on: https://gerrit.libreoffice.org/c/core/+/167731\nReviewed-by: Noel Grandin \u003cnoel.grandin@collabora.co.uk\u003e\nTested-by: Jenkins\n" }, { "commit": "e55074b33b1e3a2f630b74ae5de03a748b1624cd", "tree": "ec08e5b2f3a1dd0dc0112d69194412e35d5758b9", "parents": [ "19e1e6185bafc665b3f1ebe0775153a4c71ae84c" ], "author": { "name": "Noel Grandin", "email": "noel.grandin@collabora.co.uk", "time": "Thu May 02 15:38:03 2024 +0200" }, "committer": { "name": "Noel Grandin", "email": "noel.grandin@collabora.co.uk", "time": "Sat May 04 21:10:17 2024 +0200" }, "message": "replace createFromAscii with OUString literals in ucbhelper\n\nChange-Id: Ia8b0afb56e715798d4d43d662126cc3cedb66387\nReviewed-on: https://gerrit.libreoffice.org/c/core/+/167127\nReviewed-by: Noel Grandin \u003cnoel.grandin@collabora.co.uk\u003e\nTested-by: Jenkins\n" }, { "commit": "4f13c6c5cbd958cbd3cb79385335abe512bb6de2", "tree": "121231f3b624686fcf6e1e782fd6c7b73864a470", "parents": [ "6d3f6e77e1a21e53343339545502feecc69e6c78" ], "author": { "name": "Gabor Kelemen", "email": "gabor.kelemen.extern@allotropia.de", "time": "Fri Mar 29 13:19:08 2024 +0100" }, "committer": { "name": "Gabor Kelemen", "email": "gabor.kelemen.extern@allotropia.de", "time": "Fri Mar 29 21:21:23 2024 +0100" }, "message": "tdf#146619 Drop unused \u0027using namespace\u0027 in: ucbhelper/\n\nChange-Id: I9083ff77bc80fb1eb35305cbd3fb55bb25817b49\nReviewed-on: https://gerrit.libreoffice.org/c/core/+/165513\nTested-by: Jenkins\nReviewed-by: Gabor Kelemen \u003cgabor.kelemen.extern@allotropia.de\u003e\n" }, { "commit": "7840effb1d5efd1fd7f6798c7c504b05292a7793", "tree": "845e03d4c2cfad1d5bbcaaf9dc3ec1aeece7c864", "parents": [ "bf35f2b36fc00f9b37397422b2ee425c6a697540" ], "author": { "name": "Noel Grandin", "email": "noel.grandin@collabora.co.uk", "time": "Thu Feb 22 12:59:26 2024 +0200" }, "committer": { "name": "Noel Grandin", "email": "noel.grandin@collabora.co.uk", "time": "Fri Mar 08 07:06:13 2024 +0100" }, "message": "use more string_view\n\nfound by tweaking the stringview loplugin\n\nChange-Id: I92203ba99642bef7951ffa146184c5562cb31d09\nReviewed-on: https://gerrit.libreoffice.org/c/core/+/163744\nTested-by: Jenkins\nReviewed-by: Noel Grandin \u003cnoel.grandin@collabora.co.uk\u003e\n" }, { "commit": "59280a9ce5a15136a6fdd383aedf02c6cf7d6e96", "tree": "ae4a920bc8687df984745f347cfbb0f3b5d52101", "parents": [ "f23ee916466bd6e0d328a4e541e104445c8ecb0a" ], "author": { "name": "Noel Grandin", "email": "noel.grandin@collabora.co.uk", "time": "Thu Nov 23 10:01:44 2023 +0100" }, "committer": { "name": "Noel Grandin", "email": "noel.grandin@collabora.co.uk", "time": "Thu Nov 23 12:07:09 2023 +0100" }, "message": "tdf#158321 No error message when file doesn\u0027t exist\n\nRevert \"reduce allocations in InterceptedInteraction\"\n\nThis reverts commit e3c961e6a3917d95534652e0f982918cc1079015.\n\nChange-Id: I26ba0acaa088dff1800ccd69513056f821bd4d7f\nReviewed-on: https://gerrit.libreoffice.org/c/core/+/159762\nTested-by: Jenkins\nReviewed-by: Noel Grandin \u003cnoel.grandin@collabora.co.uk\u003e\n" }, { "commit": "d343a2b6393aec2eba0d25d7f4f390f12d1515f6", "tree": "382202d861eee7a2a1909c627c400e5bfee7b173", "parents": [ "4c40fe59893709f87e72f0dd36e859591d253189" ], "author": { "name": "Michael Stahl", "email": "michael.stahl@allotropia.de", "time": "Thu Nov 16 12:55:48 2023 +0100" }, "committer": { "name": "Michael Stahl", "email": "michael.stahl@allotropia.de", "time": "Thu Nov 16 19:15:26 2023 +0100" }, "message": "tdf#146386 deprecate, remove usage of Inet::Settings::ooInetFTPProxyName\n\n* officecfg: deprecate Inet::Settings::ooInetFTPProxyName/Port\n* ucbhelper: stop handling these settings\n* sfx2: remove SID_INET_FTP_PROXY_NAME and SID_INET_FTP_PROXY_PORT\n and usage from SfxApplication::GetOptions()\n* shell: remove proxy config code from backends\n* stoc: the JavaVM would have its \"ftp.proxyHost\" properties set based\n on officecfg values; remove that\n* sysui,vcl: remove protocol from KDE desktop files and file picker\n\nChange-Id: Iba02676cf6e519e2fa60ba925209436d38e75f49\nReviewed-on: https://gerrit.libreoffice.org/c/core/+/159500\nTested-by: Jenkins\nReviewed-by: Michael Stahl \u003cmichael.stahl@allotropia.de\u003e\n" }, { "commit": "48e4a871d926b534eb6131d16d04d68b151b2847", "tree": "acff758f6a02a4f806b8bbd6b6f2a094d68006a6", "parents": [ "92e5898fa9ffa4dd8742f5f26e790563feef286e" ], "author": { "name": "Noel Grandin", "email": "noel.grandin@collabora.co.uk", "time": "Tue Nov 14 16:01:30 2023 +0200" }, "committer": { "name": "Noel Grandin", "email": "noel.grandin@collabora.co.uk", "time": "Wed Nov 15 06:56:06 2023 +0100" }, "message": "loplugin:unusedmethods\n\nChange-Id: I1e125bbd388953491b3f869641484fea737d39ab\nReviewed-on: https://gerrit.libreoffice.org/c/core/+/159423\nTested-by: Jenkins\nReviewed-by: Noel Grandin \u003cnoel.grandin@collabora.co.uk\u003e\n" }, { "commit": "5bd143316162f29227b2f8ec4d165a3260806bde", "tree": "44c0ebb08e3e948a0126ae5605fa3a887cbab3c9", "parents": [ "a9a7ab4955bc9e18883331c78de407dd111776ea" ], "author": { "name": "Stephan Bergmann", "email": "sbergman@redhat.com", "time": "Thu Oct 19 10:30:37 2023 +0200" }, "committer": { "name": "Stephan Bergmann", "email": "sbergman@redhat.com", "time": "Fri Oct 20 16:36:04 2023 +0200" }, "message": "Extended loplugin:ostr: Automatic rewrite O[U]StringLiteral: ucbhelper\n\nChange-Id: Ib4b300e8b21f772c97dcb49d666f93d2821f0859\nReviewed-on: https://gerrit.libreoffice.org/c/core/+/158247\nTested-by: Jenkins\nReviewed-by: Stephan Bergmann \u003csbergman@redhat.com\u003e\n" }, { "commit": "176e8cf09a527438ec9b2b20ba2df23fa45226bc", "tree": "76897d74143771a9ee9249c49bbe91da9ffa0433", "parents": [ "328d6aae9e2b7a73f6672800629230f5b46d15b1" ], "author": { "name": "Mike Kaganski", "email": "mike.kaganski@collabora.com", "time": "Thu Oct 12 22:02:15 2023 +0300" }, "committer": { "name": "Mike Kaganski", "email": "mike.kaganski@collabora.com", "time": "Sat Oct 14 15:37:17 2023 +0200" }, "message": "Use exception ctors, instead of setting members later\n\nAvoids overwriting source location in message\n\nChange-Id: Ia0290c7dd1ab3ea1357712a27ecab75c7b583dd4\nReviewed-on: https://gerrit.libreoffice.org/c/core/+/157893\nTested-by: Jenkins\nReviewed-by: Mike Kaganski \u003cmike.kaganski@collabora.com\u003e\n" }, { "commit": "6056a0e320f0aabbde7adb28c42e00ed72ef2e5b", "tree": "d15bcc67ab18ecf32d769e3251d81c4c2aaf83f8", "parents": [ "ff5863d46c1730c65f27f3f6234d71b727af5ca9" ], "author": { "name": "Noel Grandin", "email": "noel.grandin@collabora.co.uk", "time": "Wed Oct 11 11:25:12 2023 +0200" }, "committer": { "name": "Noel Grandin", "email": "noel.grandin@collabora.co.uk", "time": "Thu Oct 12 16:11:29 2023 +0200" }, "message": "loplugin:unusedmethods\n\nChange-Id: I27782fb4b912d8b0d5f19cbe296c2a3b98b2bfd7\nReviewed-on: https://gerrit.libreoffice.org/c/core/+/157818\nTested-by: Jenkins\nReviewed-by: Noel Grandin \u003cnoel.grandin@collabora.co.uk\u003e\n" }, { "commit": "6d1b241ab7b2edf3f3eef26f4cc514c22849caf5", "tree": "3c8c3b278b5fe084434b0bee682575d4a41c0adb", "parents": [ "432e34fd1e0309038d0765f2497b7925c16a8ed2" ], "author": { "name": "Stephan Bergmann", "email": "sbergman@redhat.com", "time": "Wed Oct 11 13:27:51 2023 +0200" }, "committer": { "name": "Stephan Bergmann", "email": "sbergman@redhat.com", "time": "Wed Oct 11 21:53:13 2023 +0200" }, "message": "Drop o3tl::span, can use C++20 std::span directly now\n\nChange-Id: Ic21ff7bf48f07f7277979d52e99d2c5c268de83f\nReviewed-on: https://gerrit.libreoffice.org/c/core/+/157825\nTested-by: Jenkins\nReviewed-by: Stephan Bergmann \u003csbergman@redhat.com\u003e\n" }, { "commit": "e3c961e6a3917d95534652e0f982918cc1079015", "tree": "1efa9761d9d2159f06800f1f15b625a7dcc15d47", "parents": [ "fa229eb1ecbcbb7b861679158ad706e37d454526" ], "author": { "name": "Noel Grandin", "email": "noel.grandin@collabora.co.uk", "time": "Mon Oct 02 10:25:46 2023 +0200" }, "committer": { "name": "Noel Grandin", "email": "noel.grandin@collabora.co.uk", "time": "Mon Oct 02 13:07:00 2023 +0200" }, "message": "reduce allocations in InterceptedInteraction\n\nthe list of intercepted interactions is static per sub-class, so just\npass up a o3tl::span at constructor time.\n\nChange-Id: Ib45c5a3338e0eb3848486dfc707052f07492eb61\nReviewed-on: https://gerrit.libreoffice.org/c/core/+/157480\nTested-by: Jenkins\nReviewed-by: Noel Grandin \u003cnoel.grandin@collabora.co.uk\u003e\n" }, { "commit": "f88af95552f9b46e1714964d84c447327b50ed40", "tree": "74e49defd9b8491354be0fa46e3854373b240239", "parents": [ "9b30b4b1678e8be15ba51d236bd9a3e693d8d3d6" ], "author": { "name": "Michael Stahl", "email": "michael.stahl@allotropia.de", "time": "Fri Aug 18 15:09:43 2023 +0200" }, "committer": { "name": "Noel Grandin", "email": "noel.grandin@collabora.co.uk", "time": "Fri Aug 18 18:33:27 2023 +0200" }, "message": "ucbhelper,ucb,desktop: InternetProxyServer is problematic\n\nIt turns out that every single client of InternetProxyDecider simply\nconcatenates the 2 members of InternetProxyServer into a single string\nand passes it on to curl_easy_setopt(CURLOPT_PROXY), which will happily\ntake a URL including scheme and everything.\n\nIt turns out that the awful GetUnixSystemProxy() tries to cut off the\nscheme in a terrible way, but GetPACProxy() does no such thing and\nWINHTTP_PROXY_INFO::lpszProxy may or may not contain scheme in its\nentries; fix this to only separate the port and leave the rest alone.\n\nSo why do we need a InternetProxyServer struct? Because officecfg has\nseparate entries that correspond to its members, and so\nInternetProxyDecider gets separate events on its listener interface when\nany of them changes, which is easiest to handle if it stores these\nseparately.\n\nSo just return a concatenated URL with or without scheme in getProxy().\n\nChange-Id: I43c696471c8bec90667b5930fa00975adb432fe1\nReviewed-on: https://gerrit.libreoffice.org/c/core/+/155840\nTested-by: Jenkins\nReviewed-by: Noel Grandin \u003cnoel.grandin@collabora.co.uk\u003e\n" }, { "commit": "8a0c43fa86bd32b4d47fd7e46d3ed414c9282ffa", "tree": "e86094b8f194d25c74157cf0df57b89a5c7d406b", "parents": [ "da54fbce1c9101925059b980a0d9fe441bf0461f" ], "author": { "name": "Mike Kaganski", "email": "mike.kaganski@collabora.com", "time": "Wed Aug 09 14:29:54 2023 +0300" }, "committer": { "name": "Mike Kaganski", "email": "mike.kaganski@collabora.com", "time": "Wed Aug 09 20:15:43 2023 +0200" }, "message": "Use _beginthreadex instead of CreateThread\n\nThe documentation for ExitThread [1] has this comment:\n\n A thread in an executable that calls the C run-time library (CRT) should use\n the _beginthreadex and _endthreadex functions for thread management rather\n than CreateThread and ExitThread; this requires the use of the multithreaded\n version of the CRT. If a thread created using CreateThread calls the CRT,\n the CRT may terminate the process in low-memory conditions.\n\nSince ~all our code uses CRT, be safe and use _beginthreadex.\n\n[1] https://learn.microsoft.com/en-us/windows/win32/api/processthreadsapi/nf-processthreadsapi-createthread\n\nChange-Id: If3e566592e921b00240e08aa759d8cdbc421d44b\nReviewed-on: https://gerrit.libreoffice.org/c/core/+/155513\nTested-by: Jenkins\nReviewed-by: Mike Kaganski \u003cmike.kaganski@collabora.com\u003e\n" }, { "commit": "d4182557b5cba1d56041792dfddbd89a131f6ada", "tree": "cc9421c0a0b02e0b20e0bea580f1b217c5fa2e3e", "parents": [ "87276a497d9aa8a3f8ac0bfceb75d64938945f9a" ], "author": { "name": "Mike Kaganski", "email": "mike.kaganski@collabora.com", "time": "Sun Apr 23 20:15:21 2023 +0300" }, "committer": { "name": "Mike Kaganski", "email": "mike.kaganski@collabora.com", "time": "Sat May 27 20:14:40 2023 +0200" }, "message": "Use getXWeak in ucbhelper\n\nChange-Id: I6bdc3acf86854fe3f91aa09cb52d67a2b11ca8e7\nReviewed-on: https://gerrit.libreoffice.org/c/core/+/150879\nTested-by: Jenkins\nReviewed-by: Mike Kaganski \u003cmike.kaganski@collabora.com\u003e\n" }, { "commit": "31e2b4746a4a5d7661c4aa8f6a4489e50982aede", "tree": "51b30c8370df279acd636e599028d01b72cab5f1", "parents": [ "50deb478e97aa9cfd023c5fa2f9d567b0b5797c2" ], "author": { "name": "Noel Grandin", "email": "noelgrandin@gmail.com", "time": "Fri May 05 21:00:24 2023 +0200" }, "committer": { "name": "Noel Grandin", "email": "noel.grandin@collabora.co.uk", "time": "Sun May 07 08:00:46 2023 +0200" }, "message": "improve some usage of OInterfaceIteratorHelper4\n\nwe can drop the lock immediately after construction (since\nthe iterator holds a thread-safe COW link to the underlying listener\ncontainer)\n\nChange-Id: I08f8fa9ed7393747938572097f3c25f5f3f847fa\nReviewed-on: https://gerrit.libreoffice.org/c/core/+/151440\nTested-by: Jenkins\nReviewed-by: Noel Grandin \u003cnoel.grandin@collabora.co.uk\u003e\n" }, { "commit": "db9912d824c1d621fdc409b9cdd6c79caefe1327", "tree": "5a3c905b93df25b5baf3c773927778c6f7fc4389", "parents": [ "6b19f32252f8ba5540ce3b1e38f8ac6112421906" ], "author": { "name": "Noel Grandin", "email": "noel.grandin@collabora.co.uk", "time": "Thu Mar 30 10:39:24 2023 +0200" }, "committer": { "name": "Noel Grandin", "email": "noel.grandin@collabora.co.uk", "time": "Thu Mar 30 11:37:59 2023 +0000" }, "message": "loplugin:stringadd in ucbhelper..uui\n\nwhen applying my upcoming patch to also consider O[U]StringBuffer\n\nChange-Id: I49549347c1c041cc9ce103aed1fe1cc3bc1a780f\nReviewed-on: https://gerrit.libreoffice.org/c/core/+/149751\nTested-by: Jenkins\nReviewed-by: Noel Grandin \u003cnoel.grandin@collabora.co.uk\u003e\n" }, { "commit": "b4a5e6f025973b5a4ba8210168569fc1a5a34254", "tree": "da57043fb66850c47e84554aef4bc9ce24fc826a", "parents": [ "15405dc68b2e88b53585578567da13e3e99962db" ], "author": { "name": "Noel Grandin", "email": "noel.grandin@collabora.co.uk", "time": "Mon Feb 20 15:49:41 2023 +0200" }, "committer": { "name": "Noel Grandin", "email": "noel.grandin@collabora.co.uk", "time": "Mon Feb 20 17:45:49 2023 +0000" }, "message": "osl::Mutex-\u003estd::mutex in ucbhelper::FdInputStream\n\nChange-Id: I10482c3a5f9848f45463837d5d8982476b3910a7\nReviewed-on: https://gerrit.libreoffice.org/c/core/+/147340\nTested-by: Jenkins\nReviewed-by: Noel Grandin \u003cnoel.grandin@collabora.co.uk\u003e\n" }, { "commit": "0fbaff8f022a5d1a09a22dbfc6395c458bfc5bfd", "tree": "958df99590d418b419b8c24314dd8a083004435f", "parents": [ "39a956dcf5c40c95a97768346046366c93abc60f" ], "author": { "name": "Noel Grandin", "email": "noel.grandin@collabora.co.uk", "time": "Mon Feb 13 18:07:00 2023 +0200" }, "committer": { "name": "Noel Grandin", "email": "noel.grandin@collabora.co.uk", "time": "Mon Feb 13 17:01:04 2023 +0000" }, "message": "enforce proper locking when calling OInterfaceContainerHelper4\n\nChange-Id: Ic86305f3d16148925c7753200a687f36f08a6516\nReviewed-on: https://gerrit.libreoffice.org/c/core/+/146936\nTested-by: Jenkins\nReviewed-by: Noel Grandin \u003cnoel.grandin@collabora.co.uk\u003e\n" }, { "commit": "247bbdf7e071344564af70743eeb5e30f4113601", "tree": "f1b31c7cc80c132dea65171a01d69ddefaeb5403", "parents": [ "3689c2227edcde9aceea574418f54ef3a9fc603d" ], "author": { "name": "Chris Sherlock", "email": "chris.sherlock79@gmail.com", "time": "Sun Sep 11 18:49:48 2022 +1000" }, "committer": { "name": "Julien Nabet", "email": "serval2412@yahoo.fr", "time": "Mon Sep 12 18:49:28 2022 +0200" }, "message": "ucb: remove unnecessary comments\n\nChange-Id: I56b8766526972bbf75425baabcecab9f45510fd6\nReviewed-on: https://gerrit.libreoffice.org/c/core/+/139763\nTested-by: Jenkins\nReviewed-by: Julien Nabet \u003cserval2412@yahoo.fr\u003e\n" }, { "commit": "4c909d1466bf940f653984b61772cf19c320439d", "tree": "c29129af77615725b3cee5cf5e18796821b426e6", "parents": [ "91d77d65190e7cf11dd7cd0b29d5de6b66061faf" ], "author": { "name": "Noel Grandin", "email": "noel.grandin@collabora.co.uk", "time": "Tue Aug 09 15:22:23 2022 +0200" }, "committer": { "name": "Noel Grandin", "email": "noel.grandin@collabora.co.uk", "time": "Wed Aug 10 08:07:03 2022 +0200" }, "message": "loplugin:passstuffbyref\n\nChange-Id: Ib2b2650da7abc9260897f9b5aad619a0ea6ae941\nReviewed-on: https://gerrit.libreoffice.org/c/core/+/138052\nTested-by: Jenkins\nReviewed-by: Noel Grandin \u003cnoel.grandin@collabora.co.uk\u003e\n" }, { "commit": "17217a93418c9a5233eecd9491a7c4269d15057f", "tree": "871332bf42e5324d78ca18b54f4b81c07295fa71", "parents": [ "8895dc3c4cb3e3fafcde1d0243dd683e7283b805" ], "author": { "name": "Stephan Bergmann", "email": "sbergman@redhat.com", "time": "Fri Jul 01 21:07:34 2022 +0200" }, "committer": { "name": "Stephan Bergmann", "email": "sbergman@redhat.com", "time": "Fri Jul 01 23:01:33 2022 +0200" }, "message": "Use some more O3TL_UNREACHABLE\n\nChange-Id: Ibcf1b1de7b43460266e99fc9f27c1de0b510a361\nReviewed-on: https://gerrit.libreoffice.org/c/core/+/136779\nTested-by: Jenkins\nReviewed-by: Stephan Bergmann \u003csbergman@redhat.com\u003e\n" }, { "commit": "eea6b27762cdd5f831f4a83b8c5d2979652aab03", "tree": "7bd5abed3f67eb8156df80496f7af3988e90780f", "parents": [ "35ca93f7892e8f19b871f7f687a9f7e4933a65ad" ], "author": { "name": "Noel Grandin", "email": "noel.grandin@collabora.co.uk", "time": "Mon Jun 27 10:11:20 2022 +0200" }, "committer": { "name": "Noel Grandin", "email": "noel.grandin@collabora.co.uk", "time": "Mon Jun 27 13:40:26 2022 +0200" }, "message": "clang-tidy modernize-pass-by-value in ucbhelper\n\nChange-Id: I9f73760a800bee5a810add9ee0ebed3a778ddd8b\nReviewed-on: https://gerrit.libreoffice.org/c/core/+/136475\nTested-by: Jenkins\nReviewed-by: Noel Grandin \u003cnoel.grandin@collabora.co.uk\u003e\n" }, { "commit": "b4ae96a261ccb7bbaaa2f7bc844a6a0e973755d5", "tree": "84e0ddb4018b93808800596fc0ef6d4583d9a91e", "parents": [ "e8f2ccb42014b5eccabd42e5f95190be9e8f4519" ], "author": { "name": "Noel Grandin", "email": "noel.grandin@collabora.co.uk", "time": "Tue May 24 09:58:54 2022 +0200" }, "committer": { "name": "Noel Grandin", "email": "noel.grandin@collabora.co.uk", "time": "Tue May 24 13:13:00 2022 +0200" }, "message": "elide some OUString allocation\n\nChange-Id: I29df28792eb413005a85235fce7295320798ae65\nReviewed-on: https://gerrit.libreoffice.org/c/core/+/134859\nTested-by: Jenkins\nReviewed-by: Noel Grandin \u003cnoel.grandin@collabora.co.uk\u003e\n" }, { "commit": "0a1bfe1e3fb298d7d7e2cfd85887d430cce59238", "tree": "f38008d197ecb7cf1b8782fdb8ffdb1aac5edbcb", "parents": [ "e1b3a6edd4b3400c25aa135d75bd1ad19b279609" ], "author": { "name": "Noel Grandin", "email": "noel.grandin@collabora.co.uk", "time": "Mon May 23 11:04:19 2022 +0200" }, "committer": { "name": "Noel Grandin", "email": "noel.grandin@collabora.co.uk", "time": "Mon May 23 15:25:42 2022 +0200" }, "message": "elide some OUString allocation\n\nChange-Id: I5f0b9057b86ec98b66b4ce2d6c681b8cb93d49e1\nReviewed-on: https://gerrit.libreoffice.org/c/core/+/134802\nTested-by: Jenkins\nReviewed-by: Noel Grandin \u003cnoel.grandin@collabora.co.uk\u003e\n" }, { "commit": "a5af08b3ed160a569d389474dc5d5445dccf3a63", "tree": "676a9c73b4e59af2eebabb8edd4d65cdb3568130", "parents": [ "e855dc52266eab9b43f5f2f679c84eb6e30be46e" ], "author": { "name": "Noel Grandin", "email": "noel.grandin@collabora.co.uk", "time": "Fri May 06 11:52:20 2022 +0200" }, "committer": { "name": "Noel Grandin", "email": "noel.grandin@collabora.co.uk", "time": "Sat May 07 15:26:06 2022 +0200" }, "message": "tdf#121740 fast path in cancelCommandExecution\n\nskip the cost of constructing a SimpleIOErrorRequest in the common case\n\nChange-Id: Ib0a8989a9ffa76e6b71f984e0f32be94ec5cb8ff\nReviewed-on: https://gerrit.libreoffice.org/c/core/+/133959\nTested-by: Jenkins\nReviewed-by: Noel Grandin \u003cnoel.grandin@collabora.co.uk\u003e\n" }, { "commit": "9d0a8f7a2e3e473ebb3042f90dd82696dd8705da", "tree": "25f42587e714bc4f8ba5e7852682a65bc931bd67", "parents": [ "738b8f09c52a0e0234842c622786fccbb027621b" ], "author": { "name": "Noel Grandin", "email": "noelgrandin@gmail.com", "time": "Thu May 05 22:50:16 2022 +0200" }, "committer": { "name": "Noel Grandin", "email": "noel.grandin@collabora.co.uk", "time": "Fri May 06 20:57:08 2022 +0200" }, "message": "osl::Mutex-\u003estd::mutex in Content_Impl\n\nChange-Id: I5e3983958629ac732c031b9b59e96deaac63e7ca\nReviewed-on: https://gerrit.libreoffice.org/c/core/+/133913\nTested-by: Jenkins\nReviewed-by: Noel Grandin \u003cnoel.grandin@collabora.co.uk\u003e\n" }, { "commit": "4ad4c963747729c0b980ef49228f468177dc2cca", "tree": "21571ded2e06d769220b76ef63a3dabbf91df41c", "parents": [ "54d6e9f7dcea00761a47121994dd9121f54e1798" ], "author": { "name": "Stephan Bergmann", "email": "sbergman@redhat.com", "time": "Tue May 03 11:22:11 2022 +0200" }, "committer": { "name": "Stephan Bergmann", "email": "sbergman@redhat.com", "time": "Tue May 03 16:03:54 2022 +0200" }, "message": "Just use Any ctor instead of makeAny in ucbhelper\n\nChange-Id: I54169b62d93018d06655c92c0ba99fdee499a8e3\nReviewed-on: https://gerrit.libreoffice.org/c/core/+/133751\nTested-by: Jenkins\nReviewed-by: Stephan Bergmann \u003csbergman@redhat.com\u003e\n" }, { "commit": "183dd9deec869209c45378ff09f063cc9bf03e26", "tree": "414718e4170d08d36fee392cd72cbcc27920eb04", "parents": [ "38d4b6eb42246c0dbd4958a50ed8437bc93508d6" ], "author": { "name": "Noel Grandin", "email": "noel.grandin@collabora.co.uk", "time": "Fri Apr 29 09:22:20 2022 +0200" }, "committer": { "name": "Noel Grandin", "email": "noel.grandin@collabora.co.uk", "time": "Fri Apr 29 13:00:29 2022 +0200" }, "message": "Revert \"use more string_view in ucbhelper\"\n\nThis reverts commit d9c3f05dcb6c03633bbcc8d88e55237a0855d9a5.\n\nThis is likely a pessimisation since the\n OUString aToken \u003d rNoProxyList.copy( nPos, nEnd - nPos );\nwas previously likely mostly just copying the whole string in which case it would return the same object.\n\nChange-Id: I1e09630f0095d194deb72f70bba2d65c04771487\nReviewed-on: https://gerrit.libreoffice.org/c/core/+/133491\nTested-by: Jenkins\nReviewed-by: Noel Grandin \u003cnoel.grandin@collabora.co.uk\u003e\n" }, { "commit": "d9c3f05dcb6c03633bbcc8d88e55237a0855d9a5", "tree": "1884ad11b1453289155ea0b816d0f52ea1b0b01f", "parents": [ "ac1c31a577e6fb0efa05ff0ab098ee62f50cb88a" ], "author": { "name": "Noel Grandin", "email": "noel.grandin@collabora.co.uk", "time": "Wed Apr 27 20:42:35 2022 +0200" }, "committer": { "name": "Noel Grandin", "email": "noel.grandin@collabora.co.uk", "time": "Thu Apr 28 20:56:18 2022 +0200" }, "message": "use more string_view in ucbhelper\n\nChange-Id: Ief60eda8be8e184b9d637ab84fec2f8740c04396\nReviewed-on: https://gerrit.libreoffice.org/c/core/+/133554\nTested-by: Jenkins\nReviewed-by: Noel Grandin \u003cnoel.grandin@collabora.co.uk\u003e\n" }, { "commit": "bdff0bb77b57def835fcaed3bded7519e69dc896", "tree": "c330add464f566a32ebd82dd9ad29f91ba0d87f8", "parents": [ "651527b4efe9700c8c8dff58ce5aa86ad5681f16" ], "author": { "name": "Stephan Bergmann", "email": "sbergman@redhat.com", "time": "Tue Apr 26 15:08:36 2022 +0200" }, "committer": { "name": "Stephan Bergmann", "email": "sbergman@redhat.com", "time": "Tue Apr 26 17:04:01 2022 +0200" }, "message": "Use o3tl::make_unsigned in some places\n\n...where a signed and an unsigned value are compared, and the signed value has\njust been proven to be non-negative here\n\nChange-Id: I9665e6c2c4c5557f2d4cf1bb646f9fffc7bd7d30\nReviewed-on: https://gerrit.libreoffice.org/c/core/+/133442\nTested-by: Jenkins\nReviewed-by: Stephan Bergmann \u003csbergman@redhat.com\u003e\n" }, { "commit": "2b44f9490853c9de5a0e92c41fdc1279b6c91e06", "tree": "f381f0c82184c05df066fbd71a07a00da9a7345d", "parents": [ "67a5469f1cc40253453f1248622d2e52c92964ab" ], "author": { "name": "Gabor Kelemen", "email": "kelemeng@ubuntu.com", "time": "Sun Apr 10 13:11:33 2022 +0200" }, "committer": { "name": "Miklos Vajna", "email": "vmiklos@collabora.com", "time": "Tue Apr 12 15:20:47 2022 +0200" }, "message": "Recheck modules [uU]* with IWYU\n\nSee tdf#42949 for motivation\n\nChange-Id: If710445176681de8e0a0b6c65f58ecaca19dbccf\nReviewed-on: https://gerrit.libreoffice.org/c/core/+/132768\nTested-by: Jenkins\nReviewed-by: Miklos Vajna \u003cvmiklos@collabora.com\u003e\n" }, { "commit": "3e7679738413054c7e6ce973380eac501bf41cf2", "tree": "ad80f5bd2f11020fa864488792b6cc0e98a00207", "parents": [ "3bfac2a7fad9737f31443292699bd6fee6ac3a6f" ], "author": { "name": "Noel Grandin", "email": "noel.grandin@collabora.co.uk", "time": "Fri Apr 08 14:05:30 2022 +0200" }, "committer": { "name": "Noel Grandin", "email": "noel.grandin@collabora.co.uk", "time": "Fri Apr 08 20:44:43 2022 +0200" }, "message": "move comphelper::string::toInt32 to o3tl\n\nso we can use it in places where we cannot include comphelper\n\nChange-Id: Iba0ba3e4c0dcf0f9d1f09092a77c3b2010ec4f6d\nReviewed-on: https://gerrit.libreoffice.org/c/core/+/132732\nTested-by: Jenkins\nReviewed-by: Noel Grandin \u003cnoel.grandin@collabora.co.uk\u003e\n" }, { "commit": "36e0e88b28e818faf25b8e32cc8c4dc444b8a0be", "tree": "b7b5c8e13b6e05f871b01a3d0bf68c1d1329ef12", "parents": [ "cf5bbe3fce4a250ab25998053965bdc604c6114e" ], "author": { "name": "Noel Grandin", "email": "noel.grandin@collabora.co.uk", "time": "Thu Apr 07 20:54:55 2022 +0200" }, "committer": { "name": "Noel Grandin", "email": "noel.grandin@collabora.co.uk", "time": "Fri Apr 08 13:18:41 2022 +0200" }, "message": "use more subView when converting to Int32\n\nChange-Id: I54e3ddf79ba793fd4328bf8bda7f949b65349651\nReviewed-on: https://gerrit.libreoffice.org/c/core/+/132693\nTested-by: Jenkins\nReviewed-by: Noel Grandin \u003cnoel.grandin@collabora.co.uk\u003e\n" }, { "commit": "1927b51993fb68907a75765676179b08ab195196", "tree": "1b7d09c1b5e7ea945fb6ea618a4c100e8630ebb4", "parents": [ "0dfa444f393a5766d36fe7d2480d0c8ec832e329" ], "author": { "name": "Noel Grandin", "email": "noel.grandin@collabora.co.uk", "time": "Fri Apr 01 17:42:34 2022 +0200" }, "committer": { "name": "Noel Grandin", "email": "noel.grandin@collabora.co.uk", "time": "Sat Apr 02 13:31:19 2022 +0200" }, "message": "loplugin:stringviewparam convert methods using indexOf\n\n.. and lastIndexOf, which convert to find and rfind\n\nChange-Id: I6c4156cf904774c0d867f85a4c2785dba7593f62\nReviewed-on: https://gerrit.libreoffice.org/c/core/+/132445\nTested-by: Jenkins\nReviewed-by: Noel Grandin \u003cnoel.grandin@collabora.co.uk\u003e\n" }, { "commit": "4aa6a80f001124788593a25c2777c3f6b8f23361", "tree": "3f56ee029cbb78cafe3ae5c3e8f07fbf11721c01", "parents": [ "423174a7830c2cf9333c55872ef3775fabfd6962" ], "author": { "name": "Mike Kaganski", "email": "mike.kaganski@collabora.com", "time": "Sun Feb 06 15:38:38 2022 +0100" }, "committer": { "name": "Mike Kaganski", "email": "mike.kaganski@collabora.com", "time": "Sun Feb 06 17:40:51 2022 +0100" }, "message": "No need to call makeStringAndClear to pass a string view\n\nChange-Id: Ic794e91da7a8cc405116104544f02d1b659b753a\nReviewed-on: https://gerrit.libreoffice.org/c/core/+/129553\nTested-by: Jenkins\nReviewed-by: Mike Kaganski \u003cmike.kaganski@collabora.com\u003e\n" }, { "commit": "4304947164bbcd3fea758df491a730b01d578be2", "tree": "996401cf2095022d79e2459fdc0cfc9168c674dd", "parents": [ "47f21d290087638b1986c291c969bf2997574ddd" ], "author": { "name": "Noel Grandin", "email": "noel.grandin@collabora.co.uk", "time": "Fri Jan 21 09:10:08 2022 +0200" }, "committer": { "name": "Noel Grandin", "email": "noel.grandin@collabora.co.uk", "time": "Fri Jan 21 13:44:57 2022 +0100" }, "message": "fix opengl slide transition\n\nregression from\n commit 62efb188668a3296591dcfa3658185e2f982e356\n use comphelper::WeakComponentImplHelper in SlideShowVie\n\nSwitch notifyEach to leave the mutex locked after being called,\nbecause that seems to compose better - because after a call\nit is in the same state that was when we entered the call.\n\nChange-Id: I42e80cc7be1b65ed8cab24ab7c11210e056d916d\nReviewed-on: https://gerrit.libreoffice.org/c/core/+/128723\nTested-by: Jenkins\nReviewed-by: Noel Grandin \u003cnoel.grandin@collabora.co.uk\u003e\n" }, { "commit": "a2eaf99e46f370ffb3b73828c2bdc53dc193b9a4", "tree": "6d08d7b5077478a92acde6dd6e7278e98a409ce1", "parents": [ "49a5e69f567302633299bf6626a9d9b9544ee94b" ], "author": { "name": "Noel Grandin", "email": "noel.grandin@collabora.co.uk", "time": "Fri Jan 14 10:56:50 2022 +0200" }, "committer": { "name": "Noel Grandin", "email": "noel.grandin@collabora.co.uk", "time": "Fri Jan 14 21:04:10 2022 +0100" }, "message": "make comphelper::OInterfaceContainerHelper4 more threadsafe\n\n(*) make all the methods that require an external mutex take a\nstd::unique_lock as a parameter, so that call sites cannot forget\n\n(*) make the forEach method drop the lock when firing listener methods,\nto reduce the odds of deadlock\n\nChange-Id: I0a80e3b3d1c1c03b7de4a658d31fcc2847690903\nReviewed-on: https://gerrit.libreoffice.org/c/core/+/128415\nTested-by: Jenkins\nReviewed-by: Noel Grandin \u003cnoel.grandin@collabora.co.uk\u003e\n" }, { "commit": "8960dae3a24f5dd2712f1fe74de0c3b22552b12b", "tree": "6b2d56915eddf3eb07d3a401be5365c90f946e1b", "parents": [ "b32e46fbc3b536c1f56fe5d3714772ad673542a3" ], "author": { "name": "Noel Grandin", "email": "noel.grandin@collabora.co.uk", "time": "Fri Jan 14 09:41:29 2022 +0200" }, "committer": { "name": "Noel Grandin", "email": "noel.grandin@collabora.co.uk", "time": "Fri Jan 14 09:45:31 2022 +0100" }, "message": "no need to hold OInterfaceContainerHelper4 by unique_ptr\n\nwhen empty, it is only a single pointer big anyway\n\nChange-Id: I3e45dd705c4bef3799435617db1a4192d62860e4\nReviewed-on: https://gerrit.libreoffice.org/c/core/+/128403\nTested-by: Jenkins\nReviewed-by: Noel Grandin \u003cnoel.grandin@collabora.co.uk\u003e\n" }, { "commit": "58a750598cb064f7d9a4569e80ce91f22a87512d", "tree": "07f5e904d8aca1da89e3513673778b2ef23f2ee8", "parents": [ "2a5b87316625d3f5cd735f01376c263dc40e7c81" ], "author": { "name": "Noel Grandin", "email": "noelgrandin@gmail.com", "time": "Thu Dec 23 18:09:02 2021 +0200" }, "committer": { "name": "Noel Grandin", "email": "noel.grandin@collabora.co.uk", "time": "Mon Dec 27 15:21:05 2021 +0100" }, "message": "osl::Mutex-\u003estd::mutex in CommandProcessorInfo\n\nChange-Id: I7de1e3e822b272fa4719c9113089c5e4852498ff\nReviewed-on: https://gerrit.libreoffice.org/c/core/+/127543\nTested-by: Jenkins\nReviewed-by: Noel Grandin \u003cnoel.grandin@collabora.co.uk\u003e\n" }, { "commit": "42050ccb71663a776d6bc79d3f24ea0932f1245e", "tree": "b555d71a38a924c48aa8f6c307643d77a284f3ac", "parents": [ "42ac3410c0642c5c00023c3d6fb2df093af5fe94" ], "author": { "name": "Noel Grandin", "email": "noelgrandin@gmail.com", "time": "Thu Dec 23 18:05:49 2021 +0200" }, "committer": { "name": "Noel Grandin", "email": "noel.grandin@collabora.co.uk", "time": "Mon Dec 27 14:18:27 2021 +0100" }, "message": "osl::Mutex-\u003estd::mutex in PropertySetInfo\n\nChange-Id: I6db00939e9896fc2798d2eea09a7675fb9504f37\nReviewed-on: https://gerrit.libreoffice.org/c/core/+/127542\nTested-by: Jenkins\nReviewed-by: Noel Grandin \u003cnoel.grandin@collabora.co.uk\u003e\n" }, { "commit": "a709a654a5d6a761db836aca69c6d53244ae8817", "tree": "a72ed46b4cbf44974cb86c89ec26df95b6fb6243", "parents": [ "8229902963404204cc3b3615c4e75aac42c56933" ], "author": { "name": "Noel Grandin", "email": "noelgrandin@gmail.com", "time": "Thu Dec 23 18:29:25 2021 +0200" }, "committer": { "name": "Noel Grandin", "email": "noel.grandin@collabora.co.uk", "time": "Mon Dec 27 11:49:34 2021 +0100" }, "message": "osl::Mutex-\u003estd::mutex in ResultSetMetaData_Impl\n\nChange-Id: I58d67d1d52241eeb01b98972779238b7abae5a68\nReviewed-on: https://gerrit.libreoffice.org/c/core/+/127545\nTested-by: Jenkins\nReviewed-by: Noel Grandin \u003cnoel.grandin@collabora.co.uk\u003e\n" }, { "commit": "8229902963404204cc3b3615c4e75aac42c56933", "tree": "b9f0d62ea27c88136e194348942fd3bb5fb86d1c", "parents": [ "a235c8ddb1284757c97d92163bb6dea81ae6650f" ], "author": { "name": "Noel Grandin", "email": "noelgrandin@gmail.com", "time": "Thu Dec 23 18:22:55 2021 +0200" }, "committer": { "name": "Noel Grandin", "email": "noel.grandin@collabora.co.uk", "time": "Mon Dec 27 11:49:26 2021 +0100" }, "message": "osl::Mutex-\u003estd::mutex in ResultSet_Impl\n\nChange-Id: I1c1900e94893b42a3ad4a5ef58f0cfe277305344\nReviewed-on: https://gerrit.libreoffice.org/c/core/+/127544\nTested-by: Jenkins\nReviewed-by: Noel Grandin \u003cnoel.grandin@collabora.co.uk\u003e\n" }, { "commit": "a22772c4393f4b0a3d1a838f074c4d51be762388", "tree": "c042d88a80f89271ee16c476039af0b3c39e302b", "parents": [ "580b5227144c6d71b1dc2663fc741ed29f119767" ], "author": { "name": "Noel Grandin", "email": "noelgrandin@gmail.com", "time": "Fri Dec 17 18:10:08 2021 +0200" }, "committer": { "name": "Noel Grandin", "email": "noel.grandin@collabora.co.uk", "time": "Sat Dec 18 18:18:56 2021 +0100" }, "message": "osl::Mutex-\u003estd::mutex in ucbhelper::PropertyValueSet\n\nChange-Id: Ie4d3392e26a24ff3ffd9869809bb48bee7fcc2bd\nReviewed-on: https://gerrit.libreoffice.org/c/core/+/127067\nTested-by: Jenkins\nReviewed-by: Noel Grandin \u003cnoel.grandin@collabora.co.uk\u003e\n" }, { "commit": "580b5227144c6d71b1dc2663fc741ed29f119767", "tree": "9c6a503773409bd027d02f25f019bcaa5dfc55a8", "parents": [ "9547114247c09a90f283e42c4db947ae57e9529c" ], "author": { "name": "Noel Grandin", "email": "noelgrandin@gmail.com", "time": "Fri Dec 17 18:43:18 2021 +0200" }, "committer": { "name": "Noel Grandin", "email": "noel.grandin@collabora.co.uk", "time": "Sat Dec 18 18:18:32 2021 +0100" }, "message": "osl::Mutex-\u003estd::mutex in ResultSetImplHelper\n\nChange-Id: I7567369120593579740e23668d3426a25377a105\nReviewed-on: https://gerrit.libreoffice.org/c/core/+/127068\nTested-by: Jenkins\nReviewed-by: Noel Grandin \u003cnoel.grandin@collabora.co.uk\u003e\n" }, { "commit": "7994791e0a3681d46d8b257f09422b04deeae41c", "tree": "e04944776200e5bad5ac80618aaf3270a23c26d6", "parents": [ "134425eb98147d197833cb4ef7bb4d8c3d7fd2bc" ], "author": { "name": "Noel Grandin", "email": "noelgrandin@gmail.com", "time": "Thu Dec 16 16:08:48 2021 +0200" }, "committer": { "name": "Noel Grandin", "email": "noel.grandin@collabora.co.uk", "time": "Fri Dec 17 07:26:25 2021 +0100" }, "message": "use more OInterfaceContainer3::notifyEach\n\nChange-Id: I0dd6e9f1514792e73a31e81896d09c27c1912318\nReviewed-on: https://gerrit.libreoffice.org/c/core/+/126966\nTested-by: Jenkins\nReviewed-by: Noel Grandin \u003cnoel.grandin@collabora.co.uk\u003e\n" }, { "commit": "9b0ea78959f6bcbc1a776c505352ab37e91381ad", "tree": "9d4d4a6e92ede6803fda89b47b1b4bef4204e20e", "parents": [ "b67257c5dc54b37495a755005192e4cf186aef25" ], "author": { "name": "Noel Grandin", "email": "noelgrandin@gmail.com", "time": "Sun Nov 21 20:32:47 2021 +0200" }, "committer": { "name": "Noel Grandin", "email": "noel.grandin@collabora.co.uk", "time": "Mon Nov 22 07:55:24 2021 +0100" }, "message": "use more OInterfaceContainerHelper3 in ContentImplHelper_Impl\n\nChange-Id: Id4e4fca8a5a4e2d050752e666a843e7d8661ec0f\nReviewed-on: https://gerrit.libreoffice.org/c/core/+/125635\nTested-by: Jenkins\nReviewed-by: Noel Grandin \u003cnoel.grandin@collabora.co.uk\u003e\n" }, { "commit": "51b75b2eae36272289230bd63b546d527c18df19", "tree": "ad00cf37ef385ba5660223e04fc579a37bafeccd", "parents": [ "82047d042e9d5d24b334eba63fd7e4c5bbbb022e" ], "author": { "name": "Mike Kaganski", "email": "mike.kaganski@collabora.com", "time": "Fri Oct 29 10:21:30 2021 +0300" }, "committer": { "name": "Mike Kaganski", "email": "mike.kaganski@collabora.com", "time": "Sun Oct 31 21:28:26 2021 +0100" }, "message": "Prepare for removal of non-const operator[] from Sequence in ucbhelper\n\nChange-Id: I06b04e3eed46aba8aac528b2c394d60e733533a9\nReviewed-on: https://gerrit.libreoffice.org/c/core/+/124405\nTested-by: Jenkins\nReviewed-by: Mike Kaganski \u003cmike.kaganski@collabora.com\u003e\n" }, { "commit": "9afbe4178e3d32e0e50eb98357dcedc0d0c11558", "tree": "522f8326ea3daac786f06325ad0afbe13d3b1f3c", "parents": [ "0a53b7be5975b474a6fafd2c6dc8280431551d94" ], "author": { "name": "Julien Nabet", "email": "serval2412@yahoo.fr", "time": "Sun Oct 31 17:07:24 2021 +0100" }, "committer": { "name": "Julien Nabet", "email": "serval2412@yahoo.fr", "time": "Sun Oct 31 18:00:29 2021 +0100" }, "message": "Fix OSL_ENSURE in ucbhelper\n\nFollowing:\nhttps://cgit.freedesktop.org/libreoffice/core/commit/?id\u003d6d200d8e739595bd4c6310bede7d66e3c05fbb85\nloplugin:moveparam in ucbhelper\n\nChange-Id: I90bf228932887f66b7f9d2e61d2d17bfa91d1935\nReviewed-on: https://gerrit.libreoffice.org/c/core/+/124531\nTested-by: Jenkins\nReviewed-by: Julien Nabet \u003cserval2412@yahoo.fr\u003e\n" }, { "commit": "2484de6728bd11bb7949003d112f1ece2223c7a1", "tree": "1296534e396da284b38d2c478dcd2b31c4714179", "parents": [ "88375fd36899d21d3309cf8333712e02a87d3a91" ], "author": { "name": "Mike Kaganski", "email": "mike.kaganski@collabora.com", "time": "Thu Oct 14 09:25:24 2021 +0200" }, "committer": { "name": "Mike Kaganski", "email": "mike.kaganski@collabora.com", "time": "Fri Oct 15 10:36:36 2021 +0200" }, "message": "Remove non-const Sequence::begin()/end() in internal code\n\n... to avoid hidden cost of multiple COW checks, because they\ncall getArray() internally.\nThis obsoletes [loplugin:sequenceloop].\n\nAlso rename toNonConstRange to asNonConstRange, to reflect that\nthe result is a view of the sequence, not an independent object.\n\nTODO: also drop non-const operator[], but introduce operator[]\nin SequenceRange.\n\nChange-Id: Idd5fd7a3400fe65274d2a6343025e2ef8911635d\nReviewed-on: https://gerrit.libreoffice.org/c/core/+/123518\nTested-by: Jenkins\nReviewed-by: Stephan Bergmann \u003csbergman@redhat.com\u003e\nReviewed-by: Mike Kaganski \u003cmike.kaganski@collabora.com\u003e\n" }, { "commit": "8a017d25a62e878fdd32f189f0663b05d2ffb9cf", "tree": "c91ee53b5d9276ae30df785b52579a1b77a057df", "parents": [ "17d3cacfb9675268e709cfc95771ad4ce8bde75a" ], "author": { "name": "Mike Kaganski", "email": "mike.kaganski@collabora.com", "time": "Wed Oct 13 09:02:48 2021 +0300" }, "committer": { "name": "Mike Kaganski", "email": "mike.kaganski@collabora.com", "time": "Thu Oct 14 06:00:49 2021 +0200" }, "message": "Avoid COW overhead using css::uno::Sequence\n\nThe scenarios are:\n\n1. Calling sequence\u0027s begin() and end() in pairs to pass to algorithms\n (both calls use getArray(), which does the COW checks)\n2. In addition to #1, calling end() again when checking result of find\n algorithms, and/or begin() to calculate result\u0027s distance\n3. Using non-const sequences in range-based for loops, which internally\n do #1\n4. Assigning sequence to another sequence variable, and then modifying\n one of them\n\nIn many cases, the sequences could be made const, or treated as const\nfor the purposes of the algorithms (using std::as_const, std::cbegin,\nand std::cend). Where algorithm modifies the sequence, it was changed\nto only call getArray() once. For that, css::uno::toNonConstRange was\nintroduced, which returns a struct (sublclass of std::pair) with two\niterators [begin, end], that are calculated using one call to begin()\nand one call to getLength().\n\nTo handle #4, css::uno::Sequence::swap was introduced, that swaps the\ninternal pointer to uno_Sequence. So when a local Sequence variable\nshould be assigned to another variable, and the latter will be modified\nfurther, it\u0027s now possible to use swap instead, so the two sequences\nare kept independent.\n\nThe modified places were found by temporarily removing non-const end().\n\nChange-Id: I8fe2787f200eecb70744e8b77fbdf7a49653f628\nReviewed-on: https://gerrit.libreoffice.org/c/core/+/123542\nTested-by: Jenkins\nReviewed-by: Mike Kaganski \u003cmike.kaganski@collabora.com\u003e\n" }, { "commit": "0ff2a432f776d878fc17af5442f14844a9970bf7", "tree": "1a428a203626794c618afc68efd7f933f994cfec", "parents": [ "4dc362917597f0e3b890ef7d8d190749b20abce4" ], "author": { "name": "Noel Grandin", "email": "noel.grandin@collabora.co.uk", "time": "Sun Oct 10 16:54:30 2021 +0200" }, "committer": { "name": "Noel Grandin", "email": "noel.grandin@collabora.co.uk", "time": "Sun Oct 10 18:23:20 2021 +0200" }, "message": "loplugin:moveparam in ucbhelper\n\nChange-Id: Id6b03af5ecd662ce2e390bb76819cfe5d2ec05ec\nReviewed-on: https://gerrit.libreoffice.org/c/core/+/123336\nTested-by: Jenkins\nReviewed-by: Noel Grandin \u003cnoel.grandin@collabora.co.uk\u003e\n" }, { "commit": "6d200d8e739595bd4c6310bede7d66e3c05fbb85", "tree": "21fb6b69a606d341ca93ae900b91d3d687ddcc1b", "parents": [ "7c3990c38ddc5e69c89d9cb0c1a521f144e852f7" ], "author": { "name": "Noel Grandin", "email": "noel.grandin@collabora.co.uk", "time": "Wed Oct 06 19:45:33 2021 +0200" }, "committer": { "name": "Noel Grandin", "email": "noel.grandin@collabora.co.uk", "time": "Wed Oct 06 21:17:18 2021 +0200" }, "message": "loplugin:moveparam in ucbhelper\n\nChange-Id: I1b9cc0366fb8e9b2525a56816ae4f76737a31b73\nReviewed-on: https://gerrit.libreoffice.org/c/core/+/123184\nTested-by: Jenkins\nReviewed-by: Noel Grandin \u003cnoel.grandin@collabora.co.uk\u003e\n" }, { "commit": "773a7b57fa99bdda9cde59937cd1987384ae533a", "tree": "9909d560e9c14ccd9963ee4eb58a74f4f3ea6288", "parents": [ "e20d997eb3eb5c81af907718989aba4a6f9fc950" ], "author": { "name": "Noel Grandin", "email": "noelgrandin@gmail.com", "time": "Sat Aug 07 10:47:18 2021 +0200" }, "committer": { "name": "Noel Grandin", "email": "noel.grandin@collabora.co.uk", "time": "Sat Aug 07 17:17:25 2021 +0200" }, "message": "no need to use UNO_QUERY here\n\nChange-Id: I1bfe8238d7c08f27d2b21f9fe79712aba045c812\nReviewed-on: https://gerrit.libreoffice.org/c/core/+/120152\nTested-by: Jenkins\nReviewed-by: Noel Grandin \u003cnoel.grandin@collabora.co.uk\u003e\n" }, { "commit": "1597cc5b3e07dd24cb4cb10b35b1e93545e4b929", "tree": "f6ed37244e41d23e8a84327b1580e37f3dc18829", "parents": [ "0e883d6dbee8d72257f77605ae0c8a1d5bfbf044" ], "author": { "name": "Noel Grandin", "email": "noel.grandin@collabora.co.uk", "time": "Thu Jul 29 15:08:21 2021 +0200" }, "committer": { "name": "Noel Grandin", "email": "noel.grandin@collabora.co.uk", "time": "Mon Aug 02 14:43:58 2021 +0200" }, "message": "convert #defines to OUStringLiteral\n\nmostly by doing\n\n$ git grep -l \u0027#define.*\\\"\u0027 -- *.cxx\n | xargs perl -pi -e\n\u0027s/^#define\\s+(\\w+)\\s+(\\\".*\\\")/constexpr OUStringLiteral \\1 \u003d\nu\\2;/g\u0027\n\nChange-Id: Idface893449b0ef2a3c5254865a300585d752fbb\nReviewed-on: https://gerrit.libreoffice.org/c/core/+/119669\nTested-by: Jenkins\nReviewed-by: Noel Grandin \u003cnoel.grandin@collabora.co.uk\u003e\n" }, { "commit": "6c294343edc283aed0af392c09779fee572c0c4c", "tree": "977d2d8c3f6e518d0d1100377cbc470be3742c27", "parents": [ "15684e5d595289e0a94efd80bbe203ca133845f2" ], "author": { "name": "Noel Grandin", "email": "noel.grandin@collabora.co.uk", "time": "Mon Jul 19 12:27:41 2021 +0200" }, "committer": { "name": "Noel Grandin", "email": "noel.grandin@collabora.co.uk", "time": "Tue Jul 20 14:52:04 2021 +0200" }, "message": "no need to allocate Sequence separately in CommandProcessorInfo\n\nChange-Id: I7f423dbbe9d7251a99397f1293239333fe7b0cee\nReviewed-on: https://gerrit.libreoffice.org/c/core/+/119216\nTested-by: Jenkins\nReviewed-by: Noel Grandin \u003cnoel.grandin@collabora.co.uk\u003e\n" }, { "commit": "1688af45e37144991eb09664a17b01d6be8f4792", "tree": "2e24bb62fef600f39712ea7eb618eb02be777a78", "parents": [ "650818bf8387636afce9af3672abb84f29b99ee2" ], "author": { "name": "Noel Grandin", "email": "noel.grandin@collabora.co.uk", "time": "Mon Jul 19 12:26:39 2021 +0200" }, "committer": { "name": "Noel Grandin", "email": "noel.grandin@collabora.co.uk", "time": "Tue Jul 20 13:00:45 2021 +0200" }, "message": "no need to allocate Sequence separately in PropertySetInfo\n\nChange-Id: If4843c3f419fac59ae8ce52b4004ce2dbb736f6d\nReviewed-on: https://gerrit.libreoffice.org/c/core/+/119215\nTested-by: Jenkins\nReviewed-by: Noel Grandin \u003cnoel.grandin@collabora.co.uk\u003e\n" }, { "commit": "650818bf8387636afce9af3672abb84f29b99ee2", "tree": "03cdfecd9f3b621ea4e290360c81ec7187b6339e", "parents": [ "7d1175c46588c246c455cd7c8874136bf61197fd" ], "author": { "name": "Noel Grandin", "email": "noel.grandin@collabora.co.uk", "time": "Mon Jul 19 12:29:17 2021 +0200" }, "committer": { "name": "Noel Grandin", "email": "noel.grandin@collabora.co.uk", "time": "Tue Jul 20 13:00:26 2021 +0200" }, "message": "no need to allocate Sequence separately in PropertySetInfo\n\nChange-Id: Ibe558facd380e832faaf450a36249620b98ee786\nReviewed-on: https://gerrit.libreoffice.org/c/core/+/119217\nTested-by: Jenkins\nReviewed-by: Noel Grandin \u003cnoel.grandin@collabora.co.uk\u003e\n" }, { "commit": "601e9d4badd84c3c4824090f1bc39bef3b64cbd1", "tree": "90267c806f8967606a0c9769b117f6b881a8c515", "parents": [ "17d4221c047eac47e26465ddc72d13fb89284f57" ], "author": { "name": "Noel Grandin", "email": "noel.grandin@collabora.co.uk", "time": "Thu May 13 14:01:28 2021 +0200" }, "committer": { "name": "Noel Grandin", "email": "noel.grandin@collabora.co.uk", "time": "Thu May 13 17:03:26 2021 +0200" }, "message": "inline some typedefs\n\nChange-Id: I1608e03ff9f6fbc55987010e88897e034b690b3a\nReviewed-on: https://gerrit.libreoffice.org/c/core/+/115552\nTested-by: Jenkins\nReviewed-by: Noel Grandin \u003cnoel.grandin@collabora.co.uk\u003e\n" }, { "commit": "10d29c390dd58ed629dd27fe5ed35fae28eceec3", "tree": "7476cbb90fff182c5bec0a5a1ef9c41a3ad29f19", "parents": [ "a9243e626193ab4efe3a618413886773336a38e6" ], "author": { "name": "Stephan Bergmann", "email": "sbergman@redhat.com", "time": "Fri Apr 30 08:20:03 2021 +0200" }, "committer": { "name": "Stephan Bergmann", "email": "sbergman@redhat.com", "time": "Sun May 02 17:02:28 2021 +0200" }, "message": "throw() -\u003e noexcept, part 2/3: Automatic loplugin:noexcept rewrite\n\nChange-Id: I076f16d0536b534abf0ced4d76051eadb4c0e033\nReviewed-on: https://gerrit.libreoffice.org/c/core/+/114949\nTested-by: Jenkins\nReviewed-by: Stephan Bergmann \u003csbergman@redhat.com\u003e\n" }, { "commit": "75997f13ee3a71d6c994392264b0190bd7bb6756", "tree": "4dc35a2e62e41d4b1f7953367419ff3fb072635f", "parents": [ "b546af03ab9e371c70ce72562bc0a492972a8585" ], "author": { "name": "Noel Grandin", "email": "noel.grandin@collabora.co.uk", "time": "Wed Apr 21 13:48:45 2021 +0200" }, "committer": { "name": "Noel Grandin", "email": "noel.grandin@collabora.co.uk", "time": "Thu Apr 22 21:42:14 2021 +0200" }, "message": "no need to create temporaries when appending number to O[U]StringBuffer\n\nChange-Id: I36d82423b5f75010552696a66cec7e53ee265ce4\nReviewed-on: https://gerrit.libreoffice.org/c/core/+/114395\nTested-by: Jenkins\nReviewed-by: Noel Grandin \u003cnoel.grandin@collabora.co.uk\u003e\n" }, { "commit": "ea5641baeef73af60d025d185901a303844e2d85", "tree": "94b343b35e7b8805beb9a1745fe1de2f382574fb", "parents": [ "33da78c21f4243a3e469fb7df79ed1745df70078" ], "author": { "name": "Hossein", "email": "hossein.ir@gmail.com", "time": "Mon Mar 29 21:55:26 2021 +0430" }, "committer": { "name": "Adolfo Jayme Barrientos", "email": "fitojb@ubuntu.com", "time": "Wed Apr 07 17:47:16 2021 +0200" }, "message": "Updated README.md files to represent current code / use Markdown format\n\nPreviously, all of the README files have been renamed to README.md\nand now, the contents of these files were changed to use Markdown\nformat. Other than format inconsistency, some README.md files lacked\ninformation about modules, or were out of date. By using LibreOffice\n/ OpenOffice wiki and other documentation websites, these files were\nupdated. Now every README.md file has a title, and some description.\nThe top-level README.md file is changed to add links to the modules.\nThe result of processing the Markdown format README.md files can be\nseen at: https://docs.libreoffice.org/\n\nChange-Id: Ic3b0c3c064a2498d6a435253b041df010cd7797a\nReviewed-on: https://gerrit.libreoffice.org/c/core/+/113424\nTested-by: Jenkins\nReviewed-by: Michael Stahl \u003cmichael.stahl@allotropia.de\u003e\nReviewed-by: Adolfo Jayme Barrientos \u003cfitojb@ubuntu.com\u003e\n" }, { "commit": "c16158772d64cab8a4ed1f165cab57d307998e78", "tree": "424f72af3b4a877ecb9493cd64de70e4925a9bee", "parents": [ "ea184837a54fc85599d78baf59c83b6cf8bd0adb" ], "author": { "name": "Hossein", "email": "hossein.ir@gmail.com", "time": "Tue Mar 23 14:20:32 2021 +0430" }, "committer": { "name": "Christian Lohmaier", "email": "lohmaier+LibreOffice@googlemail.com", "time": "Wed Mar 24 11:46:14 2021 +0100" }, "message": "Using .md extension/Markdown syntax for modules README\n\nRenaming all README files for all top level modules to README.md,\napplying no content change at this stage to be able to track history\nof the files. These files should be edited to use correct Markdown\nsyntax later.\n\nChange-Id: I542fa3f3d32072156f16eaad2211a397cc212665\nReviewed-on: https://gerrit.libreoffice.org/c/core/+/112977\nTested-by: Jenkins\nReviewed-by: Christian Lohmaier \u003clohmaier+LibreOffice@googlemail.com\u003e\n" }, { "commit": "1ad26c9fc237e00247f18fcc8ccc778fba88d1fd", "tree": "0df230e3bfb929be219e5ef2f8d1574a83a6c959", "parents": [ "653e9627828adafc833fd179cea495f4b6e409ce" ], "author": { "name": "Noel", "email": "noel.grandin@collabora.co.uk", "time": "Thu Feb 11 16:15:15 2021 +0200" }, "committer": { "name": "Noel Grandin", "email": "noel.grandin@collabora.co.uk", "time": "Thu Feb 18 13:45:03 2021 +0100" }, "message": "loplugin:referencecasting add check for new rtl::Reference operator\n\nrtl::Reference now has a conversion operator to uno::Reference,\nso look for places where we can simplify the code and use that.\n\nChange-Id: Ic81db50d670bed5e875300577d4bf5f3599cc2c4\nReviewed-on: https://gerrit.libreoffice.org/c/core/+/110798\nTested-by: Jenkins\nReviewed-by: Noel Grandin \u003cnoel.grandin@collabora.co.uk\u003e\n" }, { "commit": "0ce7c84cc7b3f53a56a70586f73d7615f68ec1dc", "tree": "410bb933b09711440bed16f006f2556140d5ce7f", "parents": [ "cb4ba42fbf421a17a8ba0e32ef09add928f2b694" ], "author": { "name": "Stephan Bergmann", "email": "sbergman@redhat.com", "time": "Fri Feb 05 11:10:34 2021 +0100" }, "committer": { "name": "Stephan Bergmann", "email": "sbergman@redhat.com", "time": "Fri Feb 05 15:01:48 2021 +0100" }, "message": "Revert \"Fix typo in code\"\n\nThis reverts commit 3ed9bba283a6a67864c0928186e277240be0d9ba. osl_Pos_Absolut\n(include/osl/file.h) is part of the stable URE interface; it must not be changed.\n\nChange-Id: I1f49923a9351e4be5aee39b10720d38b424feb9b\nReviewed-on: https://gerrit.libreoffice.org/c/core/+/110435\nTested-by: Jenkins\nReviewed-by: Stephan Bergmann \u003csbergman@redhat.com\u003e\n" }, { "commit": "3ed9bba283a6a67864c0928186e277240be0d9ba", "tree": "47d2bb70e269839cce5aa6645e0ad596faa64529", "parents": [ "955fd7d8dc9da29717371c8fcb25d9954ff975bd" ], "author": { "name": "Andrea Gelmini", "email": "andrea.gelmini@gelma.net", "time": "Thu Feb 04 10:18:28 2021 +0100" }, "committer": { "name": "Andrea Gelmini", "email": "andrea.gelmini@gelma.net", "time": "Thu Feb 04 22:56:54 2021 +0100" }, "message": "Fix typo in code\n\nChange-Id: Ib8b306a27d25a34e784aeeb72708b0d5d1511f3c\nReviewed-on: https://gerrit.libreoffice.org/c/core/+/110394\nTested-by: Jenkins\nReviewed-by: Andrea Gelmini \u003candrea.gelmini@gelma.net\u003e\n" }, { "commit": "35e471bb4d1388cf5afcdcee214cf5111edf44e3", "tree": "bb78f4f13f131f0cb206a9707cc3cfc495a3876a", "parents": [ "0c06e77c122f10a1842bc908bd6e25b1110ddbd2" ], "author": { "name": "Stephan Bergmann", "email": "sbergman@redhat.com", "time": "Fri Dec 11 17:44:34 2020 +0100" }, "committer": { "name": "Stephan Bergmann", "email": "sbergman@redhat.com", "time": "Fri Dec 11 21:25:10 2020 +0100" }, "message": "Adapt the remaining OUString functions to std string_view\n\n...for LIBO_INTERNAL_ONLY. These had been missed by\n1b43cceaea2084a0489db68cd0113508f34b6643 \"Make many OUString functions take\nstd::u16string_view parameters\" because they did not match the multi-overload\npattern that was addressed there, but they nevertheless benefit from being\nchanged just as well (witness e.g. the various resulting changes from copy() to\nsubView()).\n\nThis showed a conversion from OStringChar to std::string_view to be missing\n(while the corresponding conversion form OUStringChar to std::u16string_view was\nalready present).\n\nThe improvement to loplugin:stringadd became necessary to fix\n\n\u003e [CPT] compilerplugins/clang/test/stringadd.cxx\n\u003e error: \u0027error\u0027 diagnostics expected but not seen:\n\u003e File ~/lo/core/compilerplugins/clang/test/stringadd.cxx Line 43 (directive at ~/lo/core/compilerplugins/clang/test/stringadd.cxx:42): simplify by merging with the preceding assignment [loplugin:stringadd]\n\u003e File ~/lo/core/compilerplugins/clang/test/stringadd.cxx Line 61 (directive at ~/lo/core/compilerplugins/clang/test/stringadd.cxx:60): simplify by merging with the preceding assignment [loplugin:stringadd]\n\u003e 2 errors generated.\n\nChange-Id: Ie40de0616a66e60e289c1af0ca60aed6f9ecc279\nReviewed-on: https://gerrit.libreoffice.org/c/core/+/107602\nTested-by: Jenkins\nReviewed-by: Stephan Bergmann \u003csbergman@redhat.com\u003e\n" }, { "commit": "bb06f51308428500c9c8d11ae05f0aa03ecc179c", "tree": "b18620e8572ed6d4c43c8605660d59f5f7a7e531", "parents": [ "42e8e16cf93dcf944e5c1106f76aaa32057c0397" ], "author": { "name": "Noel", "email": "noelgrandin@gmail.com", "time": "Wed Nov 18 10:10:40 2020 +0200" }, "committer": { "name": "Noel Grandin", "email": "noel.grandin@collabora.co.uk", "time": "Tue Nov 24 09:45:04 2020 +0100" }, "message": "loplugin:stringviewparam extend to comparison operators\n\nwhich means that some call sites have to change to use\nunicode string literals i.e. u\"foo\" instead of \"foo\"\n\nChange-Id: Ie51c3adf56d343dd1d1710777f9d2a43ee66221c\nReviewed-on: https://gerrit.libreoffice.org/c/core/+/106125\nTested-by: Jenkins\nReviewed-by: Noel Grandin \u003cnoel.grandin@collabora.co.uk\u003e\n" }, { "commit": "8e7f1188899023de3be07c99f146196b39dfd584", "tree": "8254aece17ab3a78893a8511af8e6e0f02f6f3d8", "parents": [ "1582d9a2c5ef9f28bc97a74e25c3948a7611fac1" ], "author": { "name": "Philipp Hofer", "email": "philipp.hofer@protonmail.com", "time": "Thu Nov 12 13:23:57 2020 +0100" }, "committer": { "name": "Samuel Mehrbrodt", "email": "Samuel.Mehrbrodt@cib.de", "time": "Wed Nov 18 12:14:56 2020 +0100" }, "message": "tdf#123936 Formatting files in module ucbhelper with clang-format\n\nChange-Id: Ic18cb095646f060046f83663f7b369533ffb481a\nReviewed-on: https://gerrit.libreoffice.org/c/core/+/105723\nTested-by: Jenkins\nReviewed-by: Christian Lohmaier \u003clohmaier+LibreOffice@googlemail.com\u003e\n" }, { "commit": "3d3180115be3b87e76189aea2031f0caa735dbb3", "tree": "dce74b6bac96c020617e67cd63cc69d001bb50c0", "parents": [ "93c64a61f2c84e684050294a1391cd32425b7837" ], "author": { "name": "Stephan Bergmann", "email": "sbergman@redhat.com", "time": "Wed Nov 11 09:58:09 2020 +0100" }, "committer": { "name": "Stephan Bergmann", "email": "sbergman@redhat.com", "time": "Wed Nov 11 12:37:35 2020 +0100" }, "message": "Drop some unused function parameters\n\nChange-Id: I41ad8001e78ea82bf4d893b5faaa28400ff6efcf\nReviewed-on: https://gerrit.libreoffice.org/c/core/+/105575\nTested-by: Jenkins\nReviewed-by: Stephan Bergmann \u003csbergman@redhat.com\u003e\n" }, { "commit": "cf0ed4fb4a610a61332a418f12b547648c3a0130", "tree": "8722973e4ae0f3ca82f6372f50e39863c23d62c1", "parents": [ "b6d0ca04581eae01817aac18d32a312bc9a2d514" ], "author": { "name": "Stephan Bergmann", "email": "sbergman@redhat.com", "time": "Wed Oct 14 17:48:36 2020 +0200" }, "committer": { "name": "Stephan Bergmann", "email": "sbergman@redhat.com", "time": "Wed Oct 14 22:13:38 2020 +0200" }, "message": "More fixes of uses of now-explicit OUString ctor taking raw sal_Unicode pointer\n\n...in Windows-only code, after c927aab29ebfff1ce3ac0b2f27ae343025a9890c \"Make\nthe OUString ctors taking raw sal_Unicode pointer/non-const array explicit\".\nInterestingly, these occurrences were accepted by MSVC and only cause errors\nwith clang-cl, so happened to go unnoticed until now.\n\nChange-Id: I33e7653e28a21541ef793b4b0750abb6037752db\nReviewed-on: https://gerrit.libreoffice.org/c/core/+/104314\nTested-by: Jenkins\nReviewed-by: Stephan Bergmann \u003csbergman@redhat.com\u003e\n" }, { "commit": "3c6e41f806309c2ba1f1336baa8db715ca492959", "tree": "64673466a1d0bfecd22b3e775e675426ecea5eb6", "parents": [ "8ffb4cabd9ceac529f1c2d02bd1fdeb50bd2988b" ], "author": { "name": "Andrea Gelmini", "email": "andrea.gelmini@gelma.net", "time": "Thu Aug 20 12:54:08 2020 +0200" }, "committer": { "name": "Julien Nabet", "email": "serval2412@yahoo.fr", "time": "Fri Aug 21 12:38:30 2020 +0200" }, "message": "Fix typos\n\nChange-Id: Iaf1d4aed07d1e6fcfe2392fb65cbd2fa196bcc1c\nReviewed-on: https://gerrit.libreoffice.org/c/core/+/101099\nTested-by: Jenkins\nReviewed-by: Julien Nabet \u003cserval2412@yahoo.fr\u003e\n" }, { "commit": "7281c497dec340efbcef330d88b55bcabefb8147", "tree": "fda7d8e4d673f2ba8d79ba9711cdbff5b87a831a", "parents": [ "4d9b72d1c3929eca04c7a2e363ab6214676b0f64" ], "author": { "name": "Stephan Bergmann", "email": "sbergman@redhat.com", "time": "Thu Aug 20 21:26:13 2020 +0200" }, "committer": { "name": "Stephan Bergmann", "email": "sbergman@redhat.com", "time": "Thu Aug 20 22:27:48 2020 +0200" }, "message": "Use OSL_UNREACHABLE\n\n...in those places that used some code conditional on ENABLE_LTO to work around\n(non-)unreachability wranings. This removes all uses of the ENABLE_LTO C/C++\nmacro, so it can go completely.\n\nChange-Id: I67544986cb2d3fcd8051caf87c5129bd1086408c\nReviewed-on: https://gerrit.libreoffice.org/c/core/+/101087\nTested-by: Jenkins\nReviewed-by: Stephan Bergmann \u003csbergman@redhat.com\u003e\n" }, { "commit": "3f9940c2e050830051a31e4b70736132e034a9db", "tree": "f20559316d4fc41bfc84287a67dd64498836c129", "parents": [ "89ca0ed3bc773b2fa65c74a4d3cfbdd3515bc641" ], "author": { "name": "Noel Grandin", "email": "noel.grandin@collabora.co.uk", "time": "Sun Aug 16 12:45:21 2020 +0200" }, "committer": { "name": "Noel Grandin", "email": "noel.grandin@collabora.co.uk", "time": "Sun Aug 16 15:26:37 2020 +0200" }, "message": "loplugin:unusedmethods\n\nChange-Id: I2dd10873be73256a3689233c7b1e37bde8f685ee\nReviewed-on: https://gerrit.libreoffice.org/c/core/+/100820\nTested-by: Jenkins\nReviewed-by: Noel Grandin \u003cnoel.grandin@collabora.co.uk\u003e\n" }, { "commit": "c82dae439e8081fdcbfe68b2f2bc04190077a111", "tree": "5501175c92156aa20605ca11bbb525ba83c03b55", "parents": [ "186c34af5d5758b940cf84471b3464af764d8bb7" ], "author": { "name": "Noel Grandin", "email": "noel.grandin@collabora.co.uk", "time": "Mon Aug 03 15:56:20 2020 +0200" }, "committer": { "name": "Noel Grandin", "email": "noel.grandin@collabora.co.uk", "time": "Mon Aug 03 21:54:34 2020 +0200" }, "message": "loplugin:flatten in ucbhelper\n\nChange-Id: Ic5a8ce908671bd492395bff01aa211b8bdd74ca7\nReviewed-on: https://gerrit.libreoffice.org/c/core/+/100008\nTested-by: Jenkins\nReviewed-by: Noel Grandin \u003cnoel.grandin@collabora.co.uk\u003e\n" }, { "commit": "c5b985bc9bd8d56fb012260cb1685a617261e7fc", "tree": "cff0e97b1fcd1e380236b1e2e2b203512df0109f", "parents": [ "abb6c01519a0318d7165dc9dc5b7d185353f93d6" ], "author": { "name": "Thorsten Behrens", "email": "Thorsten.Behrens@CIB.de", "time": "Mon Jul 06 03:50:20 2020 +0200" }, "committer": { "name": "Thorsten Behrens", "email": "Thorsten.Behrens@CIB.de", "time": "Fri Jul 10 02:03:40 2020 +0200" }, "message": "replace usage of blacklist with excludelist for IWYU\n\nBackground and motivation:\n https://tools.ietf.org/html/draft-knodel-terminology-02\n\nChange-Id: I2f22d455d2a936a85750eaab1fda215ebb6d9d48\nReviewed-on: https://gerrit.libreoffice.org/c/core/+/98182\nTested-by: Thorsten Behrens \u003cThorsten.Behrens@CIB.de\u003e\nReviewed-by: Thorsten Behrens \u003cThorsten.Behrens@CIB.de\u003e\n" }, { "commit": "bedc5bf125bdc0377b7dc845192b274e90945e13", "tree": "f2fa0555401ca6d547a1987f1e902d1ae8b76b35", "parents": [ "14b8c176133979cd1c3163ef5fe3eed0e6479fea" ], "author": { "name": "Stephan Bergmann", "email": "sbergman@redhat.com", "time": "Thu Jul 02 10:16:30 2020 +0200" }, "committer": { "name": "Stephan Bergmann", "email": "sbergman@redhat.com", "time": "Thu Jul 02 12:15:51 2020 +0200" }, "message": "Upcoming improved loplugin:staticanonymous -\u003e redundantstatic: ucbhelper\n\nChange-Id: Ie5e160e577ba0acc83617b2f4f2ca97b9d3f6da7\nReviewed-on: https://gerrit.libreoffice.org/c/core/+/97727\nTested-by: Jenkins\nReviewed-by: Stephan Bergmann \u003csbergman@redhat.com\u003e\n" }, { "commit": "de61e14d0b6ee90cb4d170af340275d811b9fbbf", "tree": "bebbb5d2d82144c2ef73cb9a2918196b80ee5ddd", "parents": [ "cb3e249e4dbc851f39bd80dfc7fd076543734c6d" ], "author": { "name": "Noel Grandin", "email": "noel.grandin@collabora.co.uk", "time": "Sun May 10 09:19:36 2020 +0200" }, "committer": { "name": "Noel Grandin", "email": "noel.grandin@collabora.co.uk", "time": "Sun May 10 18:28:34 2020 +0200" }, "message": "compact namespace in ucb..uui\n\nChange-Id: I644d5e418028b4b4e66cf67b20a1155a689acab0\nReviewed-on: https://gerrit.libreoffice.org/c/core/+/93906\nTested-by: Jenkins\nReviewed-by: Noel Grandin \u003cnoel.grandin@collabora.co.uk\u003e\n" }, { "commit": "b512ce255f46d90e682634e4dd17e146af7f9080", "tree": "da2ce68b775e0e45294920074a1ae8306dbac818", "parents": [ "83cf08b1cb2d493a4c12f88eb6bf0daf25fe5beb" ], "author": { "name": "Stephan Bergmann", "email": "sbergman@redhat.com", "time": "Sun Apr 26 22:07:21 2020 +0200" }, "committer": { "name": "Stephan Bergmann", "email": "sbergman@redhat.com", "time": "Mon Apr 27 07:19:30 2020 +0200" }, "message": "Make upcasting css::uno::Reference ctor require complete types\n\nThe main reason for the \"home-grown\" UpCast introduced with\n904b3d1fceee5827076758ed2a81f80cb73493ca \"Up-cast conversion constructor for\ncss::uno::Reference\" in 2013 was probably that we could not yet rely on C++11\nstd::is_base_of back then. A (welcome) side effect was that the derived class\ncould be incomplete.\n\nHowever, specializations of UpCast relying on whether or not T2 is incomplete\nare obviously an ODR violation if the type is incomplete in some TUs and\ncomplete (and derived from T1) in others. And even if UpCast had internal\nlinkage, it would still be brittle that its behavior depends on the completeness\nof T2 at the point of the template\u0027s instantiation, and not necessarily at the\npoint of use.\n\nThat means we should better base that ctor on std::is_base_of (which we can do\nnow since 39a1edd6fec902ef378acce8af42c4d7fba280d0 \"Make css::uno::Reference\nupcast ctor LIBO_INTERNAL_ONLY\"), which causes a compilation error at least on\nClang and GCC if the completeness requirements are not met. This change fixes\nall the cases where types need to be complete now, plus any resulting\nloplugin:referencecasting warnings (\"the source reference is already a subtype\nof the destination reference\").\n\nChange-Id: Ieb9e3552e90adbf2c5a5af933dcb872e20661a2f\nReviewed-on: https://gerrit.libreoffice.org/c/core/+/92950\nTested-by: Jenkins\nReviewed-by: Stephan Bergmann \u003csbergman@redhat.com\u003e\n" }, { "commit": "12a8fa0d656f3f8bad7c9f85e4f760b5201d5f75", "tree": "51bf0e790789a218b8c788ab22258180cca77e40", "parents": [ "c42cf09f17e683d7487b8b298bd2f5ff3587bf00" ], "author": { "name": "Noel Grandin", "email": "noel.grandin@collabora.co.uk", "time": "Fri Mar 13 21:12:38 2020 +0200" }, "committer": { "name": "Noel Grandin", "email": "noel.grandin@collabora.co.uk", "time": "Sun Mar 15 16:28:14 2020 +0100" }, "message": "Revert \"loplugin:constfields in ucbhelper\"\n\nThis reverts commit 64035391ebe8810520a214a3ae0aeb4c1b039819.\n\nChange-Id: Icfde3e984f9ebf93a423d101aee385182f65dea5\nReviewed-on: https://gerrit.libreoffice.org/c/core/+/90518\nTested-by: Jenkins\nReviewed-by: Noel Grandin \u003cnoel.grandin@collabora.co.uk\u003e\n" }, { "commit": "6be9ae8aa1d3b164f3953dbc1cb7f0f1c1976d9b", "tree": "244d93b2f30894d9367aae54d76b962e53a165f2", "parents": [ "ea0701aab307a549cf6cad1d309cab1bf11ef436" ], "author": { "name": "Noel Grandin", "email": "noelgrandin@gmail.com", "time": "Sun Feb 16 13:05:12 2020 +0200" }, "committer": { "name": "Noel Grandin", "email": "noel.grandin@collabora.co.uk", "time": "Mon Feb 17 08:59:01 2020 +0100" }, "message": "inline some acquire/release calls\n\nbecause these are all on the hot path, and in the best case, with\nenough inlining, the compiler can skip the call altogether and just\ndo a locked CMPXHG instruction\n\nChange-Id: I099d6385f602e40e1767f9f1002b7514ecf436e5\nReviewed-on: https://gerrit.libreoffice.org/c/core/+/88775\nTested-by: Jenkins\nReviewed-by: Noel Grandin \u003cnoel.grandin@collabora.co.uk\u003e\n" }, { "commit": "d7b0b2b50592aa73a0fd9ab8c696ac082dbed8c4", "tree": "47764c4a0ac6599edaa82e541886b5cae446989c", "parents": [ "54b28638ab15f68731861ae903c732273b41f78a" ], "author": { "name": "Noel Grandin", "email": "noel.grandin@collabora.co.uk", "time": "Mon Feb 03 14:28:33 2020 +0200" }, "committer": { "name": "Noel Grandin", "email": "noel.grandin@collabora.co.uk", "time": "Tue Feb 04 06:21:41 2020 +0100" }, "message": "move some headers inside ucbhelper\n\nChange-Id: Iccd80aa4e631abe002837ca61248e136de9a62eb\nReviewed-on: https://gerrit.libreoffice.org/c/core/+/87866\nTested-by: Jenkins\nReviewed-by: Noel Grandin \u003cnoel.grandin@collabora.co.uk\u003e\n" }, { "commit": "f656547d4d41091b5ccb729838e7355554a453cd", "tree": "baab3db9b9287d11133c5f4495b3ed4b812f0c17", "parents": [ "f51fddc2e7cfa2a2118610a3fc4b02886544d0a9" ], "author": { "name": "Noel Grandin", "email": "noel.grandin@collabora.co.uk", "time": "Tue Dec 03 09:28:27 2019 +0200" }, "committer": { "name": "Noel Grandin", "email": "noel.grandin@collabora.co.uk", "time": "Tue Dec 03 12:46:27 2019 +0100" }, "message": "remove some useless comment lines\n\nwhich merely announce that the next declaration is a class\n\nChange-Id: Ifdb1398bcd99816b13e0b3769b46d0562bfbc1dc\nReviewed-on: https://gerrit.libreoffice.org/84229\nTested-by: Jenkins\nReviewed-by: Noel Grandin \u003cnoel.grandin@collabora.co.uk\u003e\n" }, { "commit": "f853ec317f6af1b8c65cc5bd758371689c75118d", "tree": "b86d729bf9a9465ee619ead3b5635efa62a1804e", "parents": [ "f31d36966bceb90e261cbecd42634bde4448d527" ], "author": { "name": "Stephan Bergmann", "email": "sbergman@redhat.com", "time": "Tue Nov 19 16:32:49 2019 +0100" }, "committer": { "name": "Stephan Bergmann", "email": "sbergman@redhat.com", "time": "Fri Nov 22 12:57:32 2019 +0100" }, "message": "Extend loplugin:external to warn about classes\n\n...following up on 314f15bff08b76bf96acf99141776ef64d2f1355 \"Extend\nloplugin:external to warn about enums\".\n\nCases where free functions were moved into an unnamed namespace along with a\nclass, to not break ADL, are in:\n\n filter/source/svg/svgexport.cxx\n sc/source/filter/excel/xelink.cxx\n sc/source/filter/excel/xilink.cxx\n svx/source/sdr/contact/viewobjectcontactofunocontrol.cxx\n\nAll other free functions mentioning moved classes appear to be harmless and not\ngive rise to (silent, even) ADL breakage. (One remaining TODO in\ncompilerplugins/clang/external.cxx is that derived classes are not covered by\ncomputeAffectedTypes, even though they could also be affected by ADL-breakage---\nbut don\u0027t seem to be in any acutal case across the code base.)\n\nFor friend declarations using elaborate type specifiers, like\n\n class C1 {};\n class C2 { friend class C1; };\n\n* If C2 (but not C1) is moved into an unnamed namespace, the friend declaration\nmust be changed to not use an elaborate type specifier (i.e., \"friend C1;\"; see\nC++17 [namespace.memdef]/3: \"If the name in a friend declaration is neither\nqualified nor a template-id and the declaration is a function or an\nelaborated-type-specifier, the lookup to determine whether the entity has been\npreviously declared shall not consider any scopes outside the innermost\nenclosing namespace.\")\n\n* If C1 (but not C2) is moved into an unnamed namespace, the friend declaration\nmust be changed too, see \u003chttps://gcc.gnu.org/bugzilla/show_bug.cgi?id\u003d71882\u003e\n\"elaborated-type-specifier friend not looked up in unnamed namespace\".\n\nApart from that, to keep changes simple and mostly mechanical (which should help\navoid regressions), out-of-line definitions of class members have been left in\nthe enclosing (named) namespace. But explicit specializations of class\ntemplates had to be moved into the unnamed namespace to appease\n\u003chttps://gcc.gnu.org/bugzilla/show_bug.cgi?id\u003d92598\u003e \"explicit specialization of\ntemplate from unnamed namespace using unqualified-id in enclosing namespace\".\n\nAlso, accompanying declarations (of e.g. typedefs or static variables) that\ncould arguably be moved into the unnamed namespace too have been left alone.\n\nAnd in some cases, mention of affected types in blacklists in other loplugins\nneeded to be adapted.\n\nAnd sc/qa/unit/mark_test.cxx uses a hack of including other .cxx, one of which\nis sc/source/core/data/segmenttree.cxx where e.g. ScFlatUInt16SegmentsImpl is\nnot moved into an unnamed namespace (because it is declared in\nsc/inc/segmenttree.hxx), but its base ScFlatSegmentsImpl is. GCC warns about\nsuch combinations with enabled-by-default -Wsubobject-linkage, but \"The compiler\ndoesn’t give this warning for types defined in the main .C file, as those are\nunlikely to have multiple definitions.\"\n(\u003chttps://gcc.gnu.org/onlinedocs/gcc-9.2.0/gcc/Warning-Options.html\u003e) The\nwarned-about classes also don\u0027t have multiple definitions in the given test, so\ndisable the warning when including the .cxx.\n\nChange-Id: Ib694094c0d8168be68f8fe90dfd0acbb66a3f1e4\nReviewed-on: https://gerrit.libreoffice.org/83239\nTested-by: Jenkins\nReviewed-by: Stephan Bergmann \u003csbergman@redhat.com\u003e\n" }, { "commit": "5a11fe87a6f1507149a0965aa740dcdf4ccef3c3", "tree": "3f3e788a0e54c94e980bd61e4466d4d6e2c34415", "parents": [ "77d301f5e40e4f0fb4a127b8b6361a0fb1b1dbd9" ], "author": { "name": "Stephan Bergmann", "email": "sbergman@redhat.com", "time": "Tue Nov 19 15:15:50 2019 +0100" }, "committer": { "name": "Stephan Bergmann", "email": "sbergman@redhat.com", "time": "Tue Nov 19 21:34:30 2019 +0100" }, "message": "loplugin:fakebool (clang-cl)\n\n...plus follow-up loplugin:implicitboolconversion and loplugin:redundantcast\n\nChange-Id: I9fc9c5cb46fbb50da87ff80af64cb0dfda3e5f90\nReviewed-on: https://gerrit.libreoffice.org/83207\nTested-by: Jenkins\nReviewed-by: Stephan Bergmann \u003csbergman@redhat.com\u003e\n" } ], "next": "cf1b5ae4c5f7c9111a745199ac993742f9007263" }